Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37651 )
Change subject: mainboard/variant/puff: set initial PL values for puff ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37651/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37651/1/src/mainboard/google/hatch/... PS1, Line 16: variant.c mainboard.c
https://review.coreboot.org/c/coreboot/+/37651/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/variant.c:
https://review.coreboot.org/c/coreboot/+/37651/1/src/mainboard/google/hatch/... PS1, Line 1: /* call this file mainboard.c
https://review.coreboot.org/c/coreboot/+/37651/1/src/mainboard/google/hatch/... PS1, Line 89: config_t *conf = config_of_soc(); can this be avoided with `config_t * cfg = dev->chip_info;` ? that way we actually use the argument and don't rely on global state.
-
Edward O'Callaghan (Code Review)