Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47518 )
Change subject: nb/intel/sandybridge: Drop unused `rank` parameter ......................................................................
nb/intel/sandybridge: Drop unused `rank` parameter
Change-Id: I5476bbe1a99d087bc026dc5646c8440c50dd151e Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/47518/1
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 45f7a99..4bdb82d 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -716,7 +716,7 @@ write_mrreg(ctrl, channel, rank, 0, make_mr0(ctrl, rank)); }
-static odtmap get_ODT(ramctr_timing *ctrl, u8 rank, int channel) +static odtmap get_ODT(ramctr_timing *ctrl, int channel) { /* Get ODT based on rankmap */ int dimms_per_ch = (ctrl->rankmap[channel] & 1) + ((ctrl->rankmap[channel] >> 2) & 1); @@ -748,7 +748,7 @@ odtmap odt; u32 mr1reg;
- odt = get_ODT(ctrl, rank, channel); + odt = get_ODT(ctrl, channel); mr1reg = 2;
mr1reg |= encode_odt(odt.rttnom); @@ -773,7 +773,7 @@
pasr = 0; cwl = ctrl->CWL - 5; - odt = get_ODT(ctrl, rank, channel); + odt = get_ODT(ctrl, channel);
srt = ctrl->extended_temperature_range && !ctrl->auto_self_refresh;
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47518 )
Change subject: nb/intel/sandybridge: Drop unused `rank` parameter ......................................................................
Patch Set 2: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47518 )
Change subject: nb/intel/sandybridge: Drop unused `rank` parameter ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47518 )
Change subject: nb/intel/sandybridge: Drop unused `rank` parameter ......................................................................
nb/intel/sandybridge: Drop unused `rank` parameter
Change-Id: I5476bbe1a99d087bc026dc5646c8440c50dd151e Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47518 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Frans Hendriks fhendriks@eltan.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Frans Hendriks: Looks good to me, approved
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 83fea80..d3b71d5 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -706,7 +706,7 @@ write_mrreg(ctrl, channel, rank, 0, make_mr0(ctrl, rank)); }
-static odtmap get_ODT(ramctr_timing *ctrl, u8 rank, int channel) +static odtmap get_ODT(ramctr_timing *ctrl, int channel) { /* Get ODT based on rankmap */ int dimms_per_ch = (ctrl->rankmap[channel] & 1) + ((ctrl->rankmap[channel] >> 2) & 1); @@ -738,7 +738,7 @@ odtmap odt; u32 mr1reg;
- odt = get_ODT(ctrl, rank, channel); + odt = get_ODT(ctrl, channel); mr1reg = 2;
mr1reg |= encode_odt(odt.rttnom); @@ -763,7 +763,7 @@
pasr = 0; cwl = ctrl->CWL - 5; - odt = get_ODT(ctrl, rank, channel); + odt = get_ODT(ctrl, channel);
srt = ctrl->extended_temperature_range && !ctrl->auto_self_refresh;
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Frans Hendriks (Code Review)