Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50165 )
Change subject: soc/amd/picasso/fch.c: Remove unused <acpi/acpi_pm.h>
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
i've added Kyösti as reviewer here so that he's aware of this, so if it might cause an issue he's at […]
Thanks, I currently rebase often as I need to juggle things around and often only postprocess the include lines.
The file probably gets added back sometime in future, I plan to move the power-management related ACPI stuff (acpi_is_wakeup_s3, wake_source, maybe sth else) to <acpi/acpi_pm.h>. To have <acpi/acpi.h> everywhere where none of the ACPI table related functions or structs are needed is s a bit heavy to my liking.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50165
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fea31f5893227a3e076c83a1759d3795b68c943
Gerrit-Change-Number: 50165
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Tue, 02 Feb 2021 06:19:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment