Change in ...coreboot[master]: payloads/U-Boot: Use a phony target for checking out a revision

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32304

Change subject: payloads/U-Boot: Use a phony target for checking out a revision
......................................................................

payloads/U-Boot: Use a phony target for checking out a revision

Change-Id: I5ea4df33545f69c06e4ae2158a1a6c14ead784a7
Signed-off-by: Arthur Heymans 
---
M payloads/external/U-Boot/Makefile
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/32304/1

diff --git a/payloads/external/U-Boot/Makefile b/payloads/external/U-Boot/Makefile
index 653662f..c17b67f 100644
--- a/payloads/external/U-Boot/Makefile
+++ b/payloads/external/U-Boot/Makefile
@@ -51,11 +51,11 @@
    touch $(project_dir)/$(STABLE_COMMIT_ID)
 endif

-$(project_dir)/tag-$(TAG-y): fetch
+checkout: fetch
    echo "    Checking out $(project_name) revision $(TAG-y)"
    cd $(project_dir); git checkout master; git branch -D coreboot 2>/dev/null; git checkout -b coreboot $(TAG-y)

-config: $(project_dir)/$(TAG-y)
+config: checkout
    rm -f $(project_config_file)
 ifneq ($(CONFIG_PAYLOAD_CONFIGFILE),)
 ifneq ("$(wildcard $(CONFIG_PAYLOAD_CONFIGFILE))","")
@@ -83,4 +83,4 @@
 print-repo-info:
    echo "$(project_git_repo) $(project_dir)"

-.PHONY: config build clean distclean fetch print-repo-info
+.PHONY: checkout config build clean distclean fetch print-repo-info

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32304 )

Change subject: payloads/U-Boot: Use a phony target for checking out a revision
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32304 )

Change subject: payloads/U-Boot: Use a phony target for checking out a revision
......................................................................

payloads/U-Boot: Use a phony target for checking out a revision

Change-Id: I5ea4df33545f69c06e4ae2158a1a6c14ead784a7
Signed-off-by: Arthur Heymans 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32304
Tested-by: build bot (Jenkins) 
Reviewed-by: Philipp Deppenwiese 
---
M payloads/external/U-Boot/Makefile
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Philipp Deppenwiese: Looks good to me, approved

diff --git a/payloads/external/U-Boot/Makefile b/payloads/external/U-Boot/Makefile
index 653662f..c17b67f 100644
--- a/payloads/external/U-Boot/Makefile
+++ b/payloads/external/U-Boot/Makefile
@@ -51,11 +51,11 @@
    touch $(project_dir)/$(STABLE_COMMIT_ID)
 endif

-$(project_dir)/tag-$(TAG-y): fetch
+checkout: fetch
    echo "    Checking out $(project_name) revision $(TAG-y)"
    cd $(project_dir); git checkout master; git branch -D coreboot 2>/dev/null; git checkout -b coreboot $(TAG-y)

-config: $(project_dir)/$(TAG-y)
+config: checkout
    rm -f $(project_config_file)
 ifneq ($(CONFIG_PAYLOAD_CONFIGFILE),)
 ifneq ("$(wildcard $(CONFIG_PAYLOAD_CONFIGFILE))","")
@@ -83,4 +83,4 @@
 print-repo-info:
    echo "$(project_git_repo) $(project_dir)"

-.PHONY: config build clean distclean fetch print-repo-info
+.PHONY: checkout config build clean distclean fetch print-repo-info