Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Andrey Petrov, Patrick Rudolph, Julian Schroeder, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58869 )
Change subject: src/soc/amd/common/fsp: check FSP binary version. ......................................................................
Patch Set 1:
(3 comments)
File src/drivers/intel/fsp2_0/util.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132074): https://review.coreboot.org/c/coreboot/+/58869/comment/04aa6980_73dbfb1f PS1, Line 80: struct fsp_info_header *info = (struct fsp_info_header *) (fsp_file + FSP_INFO_HEADER_OFF); line over 96 characters
File src/soc/amd/common/fsp/fsp_validate.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132074): https://review.coreboot.org/c/coreboot/+/58869/comment/a093be15_a42e0550 PS1, Line 30: printk(BIOS_ERR, "#include file ImageRevisionMajorVersion=%d\n", IMAGE_REVISION_MAJOR_VERSION); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132074): https://review.coreboot.org/c/coreboot/+/58869/comment/8d9eb2ca_7a5a4b4d PS1, Line 37: printk(BIOS_ERR, "#include file ImageRevisionMinorVersion=%d\n", IMAGE_REVISION_MINOR_VERSION); line over 96 characters