[S] Change in coreboot[main]: util/superiotool: Add extra selectors support

[Angel Pons (Code Review)]

Attention is currently required from: Felix Held, Maxim, Paul Menzel.

Angel Pons has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83196?usp=email )

Change subject: util/superiotool: Add extra selectors support
......................................................................

Patch Set 2:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/83196/comment/1556ed40_c262ff5e?usp... :
PS2, Line 9: ,
nit: this comma looks odd. Were you going to add something here?
> Some chips, such as <foo bar baz>, have specific selectors ...

If not, I would prefer to remove it

https://review.coreboot.org/c/coreboot/+/83196/comment/2c8e8702_c23d7661?usp... :
PS2, Line 38: the motherboard
Which one?

File util/superiotool/superiotool.h:

https://review.coreboot.org/c/coreboot/+/83196/comment/0679afdb_a5844e75?usp... :
PS2, Line 140: typedef struct {
             : 	const char *name;
             : 	uint8_t idx;
             : 	uint8_t mask;
             : 	uint8_t val;
             : } extra_selector_t;
Please, no typedefs: https://doc.coreboot.org/contributing/coding_style.html#typedefs

```suggestion
struct extra_selector {
    const char *name;
    uint8_t idx;
    uint8_t mask;
    uint8_t val;
};
```

And replace other instances of `extra_selector_t` with `struct extra_selector`.

File util/superiotool/superiotool.c:

https://review.coreboot.org/c/coreboot/+/83196/comment/04349f99_48b5adab?usp... :
PS2, Line 87: {
nit: move brace to new line

(When in Rome, do as the Romans do)

https://review.coreboot.org/c/coreboot/+/83196/comment/d99b0ebd_593bef7e?usp... :
PS2, Line 96: (~esel->mask)
I'd say it would make more sense to invert the mask, i.e. make `esel->mask` contain ones for the bits to preserve.

https://review.coreboot.org/c/coreboot/+/83196/comment/7ffdc25f_d0347053?usp... :
PS2, Line 98: 	/* -- ESEL[27h] : 0x00 (Port Select Register) -- */
Since these comments are specific to a chip, I would prefer to remove them as they can cause confusion