Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 48:
(32 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/57519c29_f2c2c61a PS48, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/92a77e65_d7e51dcd PS48, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/beb648f5_96ffc2d5 PS48, Line 247: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/7c773eac_f1d314f6 PS48, Line 281: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/40d834b5_dd0048d2 PS48, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/7c0f5062_45533f94 PS48, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/375473df_7744ac39 PS48, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/70dea133_30d9e8c7 PS48, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/7f114a86_38ab2fc3 PS48, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/492d775d_7ef978cd PS48, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/df439de4_6f93ef31 PS48, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/e0dffe04_0efaf519 PS48, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/da7e4fb2_6a9c5a62 PS48, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/c7f6b1ef_3edeae34 PS48, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/f4043a95_8f02a1e5 PS48, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/b9318fde_621628b8 PS48, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/bcd4f021_3bb6c09b PS48, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/21840f1a_7269e201 PS48, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/3805d271_31f69a53 PS48, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/ef4da02c_b937955c PS48, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/14c6ceaa_6b43a525 PS48, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/455bf682_22953c11 PS48, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/2a4e8ec2_6ff7f986 PS48, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/020969e9_1bcc0dc4 PS48, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/67eb0623_aa7fa0ea PS48, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/44d48bf2_7609e0d9 PS48, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/940a117e_8f07cd91 PS48, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/cc44a8a7_5f706ee0 PS48, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/f9358977_9b604ee2 PS48, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/9ecafadc_59a42701 PS48, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/e43b2e59_9ada2688 PS48, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159710): https://review.coreboot.org/c/coreboot/+/23586/comment/78b61b0f_54a40095 PS48, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
-
build bot (Jenkins) (Code Review)