Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43494 )
Change subject: soc/intel/common/cpu: Update COS mask calculation for nem enhanced mode
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43494/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43494/3//COMMIT_MSG@7
PS3, Line 7: nem
NEM
https://review.coreboot.org/c/coreboot/+/43494/3//COMMIT_MSG@20
PS3, Line 20:
: Also the COS mask selection is mapped to bit 32:33 of MSR
: IA32_PQR_ASSOC(0xC8F) and need to be updated in edx(maps 63:32) before
: MSR write instead of eax(mas 31:0). This implementation corrects that
: as well.
does this mean that the enhanced mode never worked correctly in the first place? IOW, we were writing to reserved bits in IA32_PQR_ASSOC which didn't do anything here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43494
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54e047161853bfc70516c1d607aa479e68836d04
Gerrit-Change-Number: 43494
Gerrit-PatchSet: 3
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Aug 2020 17:52:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment