Change in coreboot[master]: superio/aspeed: setup early serial for AST2600 - coreboot-gerrit

9 Feb 2021


      Attention is currently required from: Jonathan Zhang.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50374 )
Change subject: superio/aspeed: setup early serial for AST2600
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
This change is ready for review.
File src/superio/aspeed/common/aspeed.h:
https://review.coreboot.org/c/coreboot/+/50374/comment/328c0bf3_93d58013 
PS1, Line 8: #include "../ast2400/ast2400.h"
do we need this ?
File src/superio/aspeed/common/early_serial.c:
https://review.coreboot.org/c/coreboot/+/50374/comment/ccadfa33_7a470c87 
PS1, Line 58: 
remove this extra line?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50374
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib21b054bea2e64e00521807e8aa13e536f643974
Gerrit-Change-Number: 50374
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam anjaneya.chagam@intel.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Daocheng Bu daocheng.bu@intel.com
Gerrit-Reviewer: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Marc Jones marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang jonzhang@fb.com
Gerrit-Comment-Date: Tue, 09 Feb 2021 17:48:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment