Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu, Ziang Wang.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81439?usp=email )
Change subject: soc/intel/xeon_sp: Add SOC_INTEL_HAS_NUMA
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File src/soc/intel/xeon_sp/numa.c:
https://review.coreboot.org/c/coreboot/+/81439/comment/0d60223b_e8a134c7 :
PS5, Line 75: #if CONFIG(SOC_INTEL_HAS_CXL)
Is this preprocessor needed? Unless something causes a compilation error on the non-CXL case, I would prefer adapting the check above:
```
/* If there are no CXL nodes, we are done */
if (!CONFIG(SOC_INTEL_HAS_CXL) || num_cxlnodes == 0)
return;
```
File src/soc/intel/xeon_sp/uncore_acpi.c:
https://review.coreboot.org/c/coreboot/+/81439/comment/c174b6a8_4c865ec9 :
PS5, Line 578: if (CONFIG(SOC_INTEL_HAS_NUMA)) {
Is there any Xeon-SP platform that is not NUMA?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81439?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I84f07c16e24e441a885144df8c805f1310acae29
Gerrit-Change-Number: 81439
Gerrit-PatchSet: 5
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Ziang Wang
ziang.wang@intel.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 29 Apr 2024 13:26:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment