Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42457 )
Change subject: lib/hardwaremain: Drop HAVE_ACPI_RESUME guards ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42457/1/src/lib/hardwaremain.c File src/lib/hardwaremain.c:
https://review.coreboot.org/c/coreboot/+/42457/1/src/lib/hardwaremain.c@155 PS1, Line 155: wake_vector = acpi_find_wakeup_vector(); The implementation was in acpi/acpi.c, not arch/acpi_s3.c. But due the fixed memory address it looks at it should be moved?
https://review.coreboot.org/c/coreboot/+/42457/1/src/lib/hardwaremain.c@171 PS1, Line 171: acpi_resume(wake_vector); I assumed --gc-sections could not drop the acpi_resume() reference.
There is chance of acpi_resume() returning, which makes preceding _exit() call wrong.
My idea some years back was to have acpi_s3_resume_allowed() as a cmos option, and mask sleepstates in SSDT(?) accordingly. I would like to keep that idea and convert remaining static CONFIG() to use that.