Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30515 )
Change subject: soc/intel/icelake: Don't use CAR_GLOBAL
......................................................................
Patch Set 4:
Patch Set 2:
Arthur, can you send RFC on the mailing list about this.
I would not mind starting to remove CAR_GLOBAL and all car_get/set_var() stuff, from the platform codes, starting with the latest Intel one so that these are no longer copied around further.
my idea is to get rid of it in our tree. CAR_GLOBAL is an empty macro if CONFIG_NO_CAR_GLOBAL_MIGRATION is set, so in the platform code it should even result in identical binaries with BUILD_TIMELESS=1. On this platform it is the case.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30515
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia210af6ef1a97da67d00036070faa1ceb3ce250b
Gerrit-Change-Number: 30515
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 10 Feb 2019 10:57:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment