Attention is currently required from: Sean Rhodes, Jeremy Soller, Nick Vaccaro, Felix Held, Elyes Haouas.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72661 )
Change subject: treewide: Remove unuseful "_HID: Hardware ID" comment
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
hm, not sure if i'd remove that, since HID means something completely different in the ACPI vs the U […]
I do think these should be documented somewhere, but not every time they're used.
For example, Documentation/acpi/uid.md mentions _HID, _CID, and _UID, but doesn't actually define what any of them mean.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72661
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5eb1424e9e6c1fbf20cd0bf68fbb52e1ec97f905
Gerrit-Change-Number: 72661
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 02 Feb 2023 14:50:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment