Attention is currently required from: Cliff Huang, Felix Held, Jérémy Compostella, Lance Zhao, Tim Wawrzynczak.
Nico Huber has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/82642?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82642/comment/505bae7b_5a7bb067?usp... :
PS1, Line 7: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option
Why?
I actually don't "remember" why I added it. However given that there
are always voices against double negatives, it seems very likely that
was the concern here. The original use was
```
if (CONFIG(ACPI_HAVE_PCAT_8259))
```
I'd like to keep that.
The other cases actually seem better as they are, too, at least to me.
A syntactical `!` seems more clear than a `NO` hidden in an identifier.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82642?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I246ecfda5bb156d151512e5dbf432a113fad51a2
Gerrit-Change-Number: 82642
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 25 May 2024 14:42:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No