Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35492 )
Change subject: mb/ocp/monolake: Add vboot RO only support ......................................................................
mb/ocp/monolake: Add vboot RO only support
Change-Id: I28a21d64e2781af294670a94c1fc88fb81e80f9e Signed-off-by: Philipp Deppenwiese zaolin@das-labor.org --- M src/mainboard/ocp/monolake/Kconfig M src/mainboard/ocp/monolake/cmos.layout A src/mainboard/ocp/monolake/vboot-ro.fmd 3 files changed, 31 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/35492/1
diff --git a/src/mainboard/ocp/monolake/Kconfig b/src/mainboard/ocp/monolake/Kconfig index 9536c30..ad4e9c7 100644 --- a/src/mainboard/ocp/monolake/Kconfig +++ b/src/mainboard/ocp/monolake/Kconfig @@ -14,6 +14,14 @@ select MAINBOARD_HAS_TPM1 select IPMI_KCS
+config VBOOT + select VBOOT_VBNV_CMOS + select VBOOT_NO_BOARD_SUPPORT + select GBB_FLAG_DISABLE_LID_SHUTDOWN + select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC + select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC + select GBB_FLAG_DISABLE_FWMP + config INTEGRATED_UART def_bool n
diff --git a/src/mainboard/ocp/monolake/cmos.layout b/src/mainboard/ocp/monolake/cmos.layout index 3c5bc3b..3aaa56b 100644 --- a/src/mainboard/ocp/monolake/cmos.layout +++ b/src/mainboard/ocp/monolake/cmos.layout @@ -81,6 +81,7 @@ 408 1 e 1 nmi 409 2 e 7 power_on_after_fail #411 5 r 0 unused +416 128 r 0 vbnv
# MRC Scrambler Seed values 896 32 r 0 mrc_scrambler_seed diff --git a/src/mainboard/ocp/monolake/vboot-ro.fmd b/src/mainboard/ocp/monolake/vboot-ro.fmd new file mode 100644 index 0000000..0530cf8 --- /dev/null +++ b/src/mainboard/ocp/monolake/vboot-ro.fmd @@ -0,0 +1,22 @@ +FLASH 16M { + SI_ALL@0x0 0x800000 { + SI_DESC@0x0 0x1000 + SI_ME@0x1000 0x7ff000 + } + SI_BIOS@0x800000 0x800000 { + MISC_RW@0x0 0x20000 { + RW_MRC_CACHE@0x0 0x10000 + RW_VPD(PRESERVE)@0x010000 0x4000 + } + WP_RO@0x020000 0x7e0000 { + RO_VPD(PRESERVE)@0x0 0x4000 + RO_SECTION@0x4000 0x7dc000 { + FMAP@0x0 0x800 + RO_FRID@0x800 0x40 + RO_FRID_PAD@0x840 0x7c0 + GBB@0x1000 0xef000 + COREBOOT(CBFS)@0xf0000 0x6ec000 + } + } + } +} \ No newline at end of file
Hello Patrick Rudolph, build bot (Jenkins), Andrey Petrov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35492
to look at the new patch set (#2).
Change subject: mb/ocp/monolake: Add vboot RO only support ......................................................................
mb/ocp/monolake: Add vboot RO only support
Change-Id: I28a21d64e2781af294670a94c1fc88fb81e80f9e Signed-off-by: Philipp Deppenwiese zaolin@das-labor.org --- M src/mainboard/ocp/monolake/Kconfig M src/mainboard/ocp/monolake/cmos.layout A src/mainboard/ocp/monolake/vboot-ro.fmd 3 files changed, 31 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/35492/2
Hello Patrick Rudolph, build bot (Jenkins), Andrey Petrov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35492
to look at the new patch set (#3).
Change subject: mb/ocp/monolake: Add vboot RO only support ......................................................................
mb/ocp/monolake: Add vboot RO only support
Change-Id: I28a21d64e2781af294670a94c1fc88fb81e80f9e Signed-off-by: Philipp Deppenwiese zaolin@das-labor.org --- M src/mainboard/ocp/monolake/Kconfig M src/mainboard/ocp/monolake/cmos.layout A src/mainboard/ocp/monolake/vboot-ro.fmd 3 files changed, 31 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/35492/3
Hello Patrick Rudolph, build bot (Jenkins), Andrey Petrov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35492
to look at the new patch set (#4).
Change subject: mb/ocp/monolake: Add vboot RO only support ......................................................................
mb/ocp/monolake: Add vboot RO only support
Change-Id: I28a21d64e2781af294670a94c1fc88fb81e80f9e Signed-off-by: Philipp Deppenwiese zaolin@das-labor.org --- M src/mainboard/ocp/monolake/Kconfig M src/mainboard/ocp/monolake/cmos.layout A src/mainboard/ocp/monolake/vboot-ro.fmd 3 files changed, 31 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/35492/4
Hello Patrick Rudolph, build bot (Jenkins), Andrey Petrov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35492
to look at the new patch set (#5).
Change subject: mb/ocp/monolake: Add vboot RO only support ......................................................................
mb/ocp/monolake: Add vboot RO only support
Change-Id: I28a21d64e2781af294670a94c1fc88fb81e80f9e Signed-off-by: Philipp Deppenwiese zaolin@das-labor.org --- M src/mainboard/ocp/monolake/Kconfig M src/mainboard/ocp/monolake/cmos.layout A src/mainboard/ocp/monolake/vboot-ro.fmd 3 files changed, 31 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/35492/5
Hello Patrick Rudolph, build bot (Jenkins), Andrey Petrov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35492
to look at the new patch set (#6).
Change subject: mb/ocp/monolake: Add vboot RO only support ......................................................................
mb/ocp/monolake: Add vboot RO only support
Change-Id: I28a21d64e2781af294670a94c1fc88fb81e80f9e Signed-off-by: Philipp Deppenwiese zaolin@das-labor.org --- M src/mainboard/ocp/monolake/Kconfig M src/mainboard/ocp/monolake/cmos.layout A src/mainboard/ocp/monolake/vboot-ro.fmd 3 files changed, 31 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/35492/6
Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35492 )
Change subject: mb/ocp/monolake: Add vboot RO only support ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35492 )
Change subject: mb/ocp/monolake: Add vboot RO only support ......................................................................
mb/ocp/monolake: Add vboot RO only support
Change-Id: I28a21d64e2781af294670a94c1fc88fb81e80f9e Signed-off-by: Philipp Deppenwiese zaolin@das-labor.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/35492 Reviewed-by: Andrey Petrov anpetrov@fb.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/ocp/monolake/Kconfig M src/mainboard/ocp/monolake/cmos.layout A src/mainboard/ocp/monolake/vboot-ro.fmd 3 files changed, 31 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Andrey Petrov: Looks good to me, approved
diff --git a/src/mainboard/ocp/monolake/Kconfig b/src/mainboard/ocp/monolake/Kconfig index 9536c30..ad4e9c7 100644 --- a/src/mainboard/ocp/monolake/Kconfig +++ b/src/mainboard/ocp/monolake/Kconfig @@ -14,6 +14,14 @@ select MAINBOARD_HAS_TPM1 select IPMI_KCS
+config VBOOT + select VBOOT_VBNV_CMOS + select VBOOT_NO_BOARD_SUPPORT + select GBB_FLAG_DISABLE_LID_SHUTDOWN + select GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC + select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC + select GBB_FLAG_DISABLE_FWMP + config INTEGRATED_UART def_bool n
diff --git a/src/mainboard/ocp/monolake/cmos.layout b/src/mainboard/ocp/monolake/cmos.layout index 3c5bc3b..3aaa56b 100644 --- a/src/mainboard/ocp/monolake/cmos.layout +++ b/src/mainboard/ocp/monolake/cmos.layout @@ -81,6 +81,7 @@ 408 1 e 1 nmi 409 2 e 7 power_on_after_fail #411 5 r 0 unused +416 128 r 0 vbnv
# MRC Scrambler Seed values 896 32 r 0 mrc_scrambler_seed diff --git a/src/mainboard/ocp/monolake/vboot-ro.fmd b/src/mainboard/ocp/monolake/vboot-ro.fmd new file mode 100644 index 0000000..44be337 --- /dev/null +++ b/src/mainboard/ocp/monolake/vboot-ro.fmd @@ -0,0 +1,22 @@ +FLASH 16M { + SI_ALL@0x0 0x800000 { + SI_DESC@0x0 0x1000 + SI_ME@0x1000 0x7ff000 + } + SI_BIOS@0x800000 0x800000 { + MISC_RW@0x0 0x20000 { + RW_MRC_CACHE@0x0 0x10000 + RW_VPD(PRESERVE)@0x010000 0x4000 + } + WP_RO@0x020000 0x7e0000 { + RO_VPD(PRESERVE)@0x0 0x4000 + RO_SECTION@0x4000 0x7dc000 { + FMAP@0x0 0x800 + RO_FRID@0x800 0x40 + RO_FRID_PAD@0x840 0x7c0 + GBB@0x1000 0x4000 + COREBOOT(CBFS)@0x5000 0x7d7000 + } + } + } +}
-
Andrey Petrov (Code Review) -
Patrick Georgi (Code Review)
-
Philipp Deppenwiese (Code Review)