Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51539 )
Change subject: mb/google/guybrush: Configure TPM i2c gpio in early stage
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/51539/comment/1ca0dc42_b0c0348a
PS1, Line 166: /* I2C0_SCL - TPM */
: PAD_NF(GPIO_145, I2C0_SCL, PULL_NONE),
: /* I2C0_SDA - TPM */
: PAD_NF(GPIO_146, I2C0_SDA, PULL_NONE),
Please refer to CB:51544. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51539
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a1e9d39028f71bbfe64d7334cabde253aab934e
Gerrit-Change-Number: 51539
Gerrit-PatchSet: 1
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 16 Mar 2021 20:45:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment