Change in coreboot[master]: device/azalia_device.c: Remove debug prints

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

5 Dec 2020 5 Dec '20

7:20 p.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48347 )

Change subject: device/azalia_device.c: Remove debug prints ......................................................................

device/azalia_device.c: Remove debug prints

The other six copies of this function in the tree do not have these debug prints. Remove them from here for consistency.

Change-Id: I999032af1628bf8d66a057dc72368f02ef6eb8d1 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/device/azalia_device.c 1 file changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/48347/1

diff --git a/src/device/azalia_device.c b/src/device/azalia_device.c index 543d5cb..e12ffad 100644 --- a/src/device/azalia_device.c +++ b/src/device/azalia_device.c @@ -87,9 +87,6 @@

static u32 find_verb(struct device *dev, u32 viddid, const u32 **verb) { - printk(BIOS_DEBUG, "azalia_audio: dev=%s\n", dev_path(dev)); - printk(BIOS_DEBUG, "azalia_audio: Reading viddid=%x\n", viddid); - int idx = 0;

while (idx < (cim_verb_data_size / sizeof(u32))) {

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Angel Pons (Code Review)

5 Dec 5 Dec

7:32 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48347

to look at the new patch set (#2).

Change subject: device/azalia_device.c: Remove debug prints ......................................................................

device/azalia_device.c: Remove debug prints

The other five copies of this function in the tree do not have these debug prints. Remove them from here for consistency.

Change-Id: I999032af1628bf8d66a057dc72368f02ef6eb8d1 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/device/azalia_device.c 1 file changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/48347/2

Michael Niewöhner (Code Review)

9:29 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48347 )

Change subject: device/azalia_device.c: Remove debug prints ......................................................................

Patch Set 5:

What for? Why not the other way round and add it to the others?

-- To view, visit https://review.coreboot.org/c/coreboot/+/48347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I999032af1628bf8d66a057dc72368f02ef6eb8d1 Gerrit-Change-Number: 48347 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 05 Dec 2020 19:29:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

9:49 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48347 )

Change subject: device/azalia_device.c: Remove debug prints ......................................................................

Patch Set 5:

...

Patch Set 5:

What for? Why not the other way round and add it to the others?

Majority: this is the odd one out. Plus, these prints only clutter the log.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I999032af1628bf8d66a057dc72368f02ef6eb8d1 Gerrit-Change-Number: 48347 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 05 Dec 2020 19:49:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

9 Dec 9 Dec

12:50 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48347 )

Change subject: device/azalia_device.c: Remove debug prints ......................................................................

Patch Set 5: Code-Review+2

...

...
What for? Why not the other way round and add it to the others?

Majority: this is the odd one out. Plus, these prints only clutter the log.

The information is already printed right before the call, so it seems odd indeed.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I999032af1628bf8d66a057dc72368f02ef6eb8d1 Gerrit-Change-Number: 48347 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 08 Dec 2020 22:50:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

15 Dec 15 Dec

6:36 p.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48347 )

Change subject: device/azalia_device.c: Remove debug prints ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I999032af1628bf8d66a057dc72368f02ef6eb8d1 Gerrit-Change-Number: 48347 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Dec 2020 16:36:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

8:02 p.m.

Hello Felix Singer, build bot (Jenkins), Nico Huber, Arthur Heymans, Michael Niewöhner, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48347

to look at the new patch set (#6).

Change subject: device/azalia_device.c: Remove debug prints ......................................................................

device/azalia_device.c: Remove debug prints

The other five copies of this function in the tree do not have these debug prints. Remove them from here for consistency. Note that this information is already printed elsewhere, so nothing is being lost.

Change-Id: I999032af1628bf8d66a057dc72368f02ef6eb8d1 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/device/azalia_device.c 1 file changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/48347/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/48347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I999032af1628bf8d66a057dc72368f02ef6eb8d1 Gerrit-Change-Number: 48347 Gerrit-PatchSet: 6 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Patrick Rudolph (Code Review)

16 Dec 16 Dec

3:09 p.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48347 )

Change subject: device/azalia_device.c: Remove debug prints ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I999032af1628bf8d66a057dc72368f02ef6eb8d1 Gerrit-Change-Number: 48347 Gerrit-PatchSet: 6 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 16 Dec 2020 13:09:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

17 Dec 17 Dec

3:53 p.m.

Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48347 )

Change subject: device/azalia_device.c: Remove debug prints ......................................................................

device/azalia_device.c: Remove debug prints

Change-Id: I999032af1628bf8d66a057dc72368f02ef6eb8d1 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48347 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/device/azalia_device.c 1 file changed, 0 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved

diff --git a/src/device/azalia_device.c b/src/device/azalia_device.c index 543d5cb..e12ffad 100644 --- a/src/device/azalia_device.c +++ b/src/device/azalia_device.c @@ -87,9 +87,6 @@

while (idx < (cim_verb_data_size / sizeof(u32))) {

-- To view, visit https://review.coreboot.org/c/coreboot/+/48347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I999032af1628bf8d66a057dc72368f02ef6eb8d1 Gerrit-Change-Number: 48347 Gerrit-PatchSet: 7 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1491

days inactive

1503

days old

coreboot-gerrit@coreboot.org

8 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Hung-Te Lin (Code Review)
Michael Niewöhner (Code Review)
Nico Huber (Code Review)
Patrick Rudolph (Code Review)