Change in coreboot[master]: intel/i440bx: Use smbus_read_byte() for raminit debug

[Keith Hui (Code Review)]

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38381 )

Change subject: intel/i440bx: Use smbus_read_byte() for raminit debug
......................................................................

intel/i440bx: Use smbus_read_byte() for raminit debug

Build broke with CONFIG_DEBUG_RAM_SETUP enabled after commit 3f882faf.
This is the fix.

Change-Id: Ib83885fc50c8fab61ced5ff18f22aa4655c5aaab
Signed-off-by: Keith Hui 
---
M src/northbridge/intel/i440bx/debug.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/38381/1

diff --git a/src/northbridge/intel/i440bx/debug.c b/src/northbridge/intel/i440bx/debug.c
index 7df639b..fe1f9c8 100644
--- a/src/northbridge/intel/i440bx/debug.c
+++ b/src/northbridge/intel/i440bx/debug.c
@@ -14,6 +14,7 @@
 #include <console/console.h>
 #include <device/pci_ops.h>
 #include <spd.h>
+#include <southbridge/intel/i82371eb/i82371eb.h>
 #include "raminit.h"

void dump_spd_registers(void)
@@ -32,7 +33,7 @@
    			if ((j & 0xf) == 0) {
    				printk(BIOS_DEBUG, "\n%02x: ", j);
    			}
-				status = spd_read_byte(device, j);
+				status = smbus_read_byte(device, j);
    			if (status < 0) {
    				printk(BIOS_DEBUG, "bad device\n");
    				break;

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38381 )

Change subject: intel/i440bx: Use smbus_read_byte() for raminit debug
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/38381/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38381/1//COMMIT_MSG@9 
PS1, Line 9: Build broke with CONFIG_DEBUG_RAM_SETUP enabled after commit 3f882faf.
Please use

… commit 3f882fa0 (intel/i440bx,i82371: Remove wrapper spd_read_byte()) …

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38381 )

Change subject: intel/i440bx: Use smbus_read_byte() for raminit debug
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/38381/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38381/1//COMMIT_MSG@9 
PS1, Line 9: Build broke with CONFIG_DEBUG_RAM_SETUP
You might want to put a config file in /configs so that it gets build-tested.

[Keith Hui (Code Review)]

Hello Kyösti Mälkki, Patrick Rudolph, Angel Pons, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38381

to look at the new patch set (#2).

Change subject: intel/i440bx: Use smbus_read_byte() for raminit debug
......................................................................

intel/i440bx: Use smbus_read_byte() for raminit debug

Build broke with CONFIG_DEBUG_RAM_SETUP enabled after commit 3f882faf
(intel/i440bx,i82371: Remove wrapper spd_read_byte()).
This is the fix.

Change-Id: Ib83885fc50c8fab61ced5ff18f22aa4655c5aaab
Signed-off-by: Keith Hui 
---
M src/northbridge/intel/i440bx/debug.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/38381/2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38381 )

Change subject: intel/i440bx: Use smbus_read_byte() for raminit debug
......................................................................

Patch Set 3: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38381 )

Change subject: intel/i440bx: Use smbus_read_byte() for raminit debug
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38381/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38381/1//COMMIT_MSG@9 
PS1, Line 9: Build broke with CONFIG_DEBUG_RAM_SETUP
> You might want to put a config file in /configs so that it gets build-tested.

+1 on adding a config file that exercises this option (can, and probably should be in a separate commit, but please do so before marking this comment "resolved")

https://review.coreboot.org/c/coreboot/+/38381/1//COMMIT_MSG@9 
PS1, Line 9: Build broke with CONFIG_DEBUG_RAM_SETUP enabled after commit 3f882faf.
> Please use […]

Done

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38381 )

Change subject: intel/i440bx: Use smbus_read_byte() for raminit debug
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38381/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38381/1//COMMIT_MSG@9 
PS1, Line 9: Build broke with CONFIG_DEBUG_RAM_SETUP
> +1 on adding a config file that exercises this option (can, and probably should be in a separate com […]

Note that the three changes of the patch train are only depending on this to be done. It's just running "make savedefconfig" and moving `defconfig` to `configs/`

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38381 )

Change subject: intel/i440bx: Use smbus_read_byte() for raminit debug
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38381/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38381/1//COMMIT_MSG@9 
PS1, Line 9: Build broke with CONFIG_DEBUG_RAM_SETUP
> Note that the three changes of the patch train are only depending on this to be done. […]

CB:38581

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38381 )

Change subject: intel/i440bx: Use smbus_read_byte() for raminit debug
......................................................................

intel/i440bx: Use smbus_read_byte() for raminit debug

Build broke with CONFIG_DEBUG_RAM_SETUP enabled after commit 3f882faf
(intel/i440bx,i82371: Remove wrapper spd_read_byte()).
This is the fix.

Change-Id: Ib83885fc50c8fab61ced5ff18f22aa4655c5aaab
Signed-off-by: Keith Hui 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38381
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/northbridge/intel/i440bx/debug.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/northbridge/intel/i440bx/debug.c b/src/northbridge/intel/i440bx/debug.c
index 7df639b..fe1f9c8 100644
--- a/src/northbridge/intel/i440bx/debug.c
+++ b/src/northbridge/intel/i440bx/debug.c
@@ -14,6 +14,7 @@
 #include <console/console.h>
 #include <device/pci_ops.h>
 #include <spd.h>
+#include <southbridge/intel/i82371eb/i82371eb.h>
 #include "raminit.h"

void dump_spd_registers(void)
@@ -32,7 +33,7 @@
    			if ((j & 0xf) == 0) {
    				printk(BIOS_DEBUG, "\n%02x: ", j);
    			}
-				status = spd_read_byte(device, j);
+				status = smbus_read_byte(device, j);
    			if (status < 0) {
    				printk(BIOS_DEBUG, "bad device\n");
    				break;