Attention is currently required from: Paul Menzel, Shelley Chen, Vamshi Krishna Gopal.
Poornima Tom has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79723?usp=email )
Change subject: mb/google/brox: Enable HDA Codec-ALC256 ......................................................................
Patch Set 3:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79723/comment/0bfb183a_d2616d2d : PS2, Line 7: Enable High Definition Audio :
Please include the model names.
Done
https://review.coreboot.org/c/coreboot/+/79723/comment/4470ae94_13fe8327 : PS2, Line 9: Added verbtable
Add verb table …
Done
https://review.coreboot.org/c/coreboot/+/79723/comment/a5d76451_4c7800b7 : PS2, Line 9: .Added
Please add a space after the dot/period.
Done
https://review.coreboot.org/c/coreboot/+/79723/comment/63e933d9_a40b675f : PS2, Line 10: added
add
Done
https://review.coreboot.org/c/coreboot/+/79723/comment/47932a59_efdb36eb : PS2, Line 9: On Brox, HDA Codec used is ALC 256.Added verbtable : for the same. Also, added the related device tree : changes for HDA related registers.
Please reflow for 72 characters per line.
Done
File src/mainboard/google/brox/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/79723/comment/4b71689a_7822556a : PS2, Line 59: * Disable AGC and set AGC limit to -1.5d
What unit is d?
corrected to unit to dB
https://review.coreboot.org/c/coreboot/+/79723/comment/1882c0c3_c815ed6a : PS2, Line 75: enableing
enabling?
Done
https://review.coreboot.org/c/coreboot/+/79723/comment/ba4c355e_31d00a7a : PS2, Line 91: * Default setting-1
Please add a space.
Done