Attention is currently required from: Lance Zhao, Caveh Jalali, Tim Wawrzynczak, Kyösti Mälkki, Boris Mittelberg.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74524 )
Change subject: [WIP] ACPI: Add usb_charge_mode_from_gnvs()
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/auron/smihandler.c:
https://review.coreboot.org/c/coreboot/+/74524/comment/5dd7c592_407addeb
PS6, Line 39: chromeec_set_usb_charge_mode(slp_typ);
Seems to me like these are all using GNVS for no reason at all, seems to be a static board customisation value that does not change runtime?
yes, it's very odd, not sure why it was done this way
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74524
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e6f37a023b0e9317dcf0355dfa70e28d51cdad9
Gerrit-Change-Number: 74524
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Sat, 29 Apr 2023 15:03:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment