Attention is currently required from: Matt DeVillier, Michał Żygowski, Piotr Król.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79893?usp=email )
Change subject: sb/amd/pi/hudson/Kconfig: replace HUDSON_LEGACY_FREE option
......................................................................
Patch Set 1:
(1 comment)
File src/southbridge/amd/pi/hudson/fadt.c:
https://review.coreboot.org/c/coreboot/+/79893/comment/935e1202_63ca5db7 :
PS1, Line 38: fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE; /* See table 5-10 */
: if (CONFIG(HUDSON_FADT_LEGACY_DEVICES))
: fadt->iapc_boot_arch |= ACPI_FADT_LEGACY_DEVICES;
: if (CONFIG(HUDSON_FADT_8042))
: fadt->iapc_boot_arch |= ACPI_FADT_8042;
I'm curious whether the compiler creates code with one write. […]
since those are all build-time constants, i'd expect the compiler to fully optimize this. and even if it won't there won't be much of a performance impact
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79893?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id4ff85630c90fb2ae8c8826bbc9049a08668210d
Gerrit-Change-Number: 79893
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Thu, 11 Jan 2024 22:37:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment