Change in coreboot[master]: mb/google/poppy/variants/nami: Add gpio-keys ACPI node for PENH
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/25162 )
Change subject: mb/google/poppy/variants/nami: Add gpio-keys ACPI node for PENH ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nami/devicetree.cb:
https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants/... PS1, Line 281: register "generic.disable_gpio_export_in_crs" = "1" register "generic.wake" = "GPE0_DW2_01"
https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nami/gpio.c:
https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants/... PS1, Line 215: PAD_CFG_GPI_GPIO_DRIVER This should be ACPI_SCI
https://review.coreboot.org/#/c/25162/1/src/mainboard/google/poppy/variants/... PS1, Line 229: ACPI_SCI and this should be GPIO_DRIVER
-
Furquan Shaikh (Code Review)