Gaggery Tsai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31406
Change subject: mb/google/poppy/variants/atlas: Add bus_speed for audio components ......................................................................
mb/google/poppy/variants/atlas: Add bus_speed for audio components
This patch sets bus_speed property for audio components to fast speed. Otherwise, the default i2c clock is standard speed in max98373 and da7219 driver.
BUG=b:123651555 BRANCH=None TEST=emerge-atlas coreboot chromeos-bootimage & check the i2c clock freqeuncy from LA is at 400KHz.
Change-Id: I073ceecd837d343a960621f4b0d797462902a0cc Signed-off-by: Gaggery Tsai gaggery.tsai@intel.com --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/31406/1
diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index 275b27d..b5a24f3 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -316,6 +316,7 @@ register "uid" = "0" register "desc" = ""RIGHT SPEAKER AMP"" register "name" = ""MAXR"" + register "bus_speed" = "I2C_SPEED_FAST" device i2c 31 on end end chip drivers/i2c/max98373 @@ -324,6 +325,7 @@ register "uid" = "1" register "desc" = ""LEFT SPEAKER AMP"" register "name" = ""MAXL"" + register "bus_speed" = "I2C_SPEED_FAST" device i2c 32 on end end chip drivers/i2c/da7219 @@ -341,6 +343,7 @@ register "adc_1bit_rpt" = "1" register "micbias_lvl" = "2600" register "mic_amp_in_sel" = ""diff"" + register "bus_speed" = "I2C_SPEED_FAST" device i2c 1a on end end end # I2C #4 - Audio
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31406 )
Change subject: mb/google/poppy/variants/atlas: Add bus_speed for audio components ......................................................................
Patch Set 1:
I have changed the driver to set this by default: https://review.coreboot.org/c/coreboot/+/31407
Gaggery Tsai has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31406 )
Change subject: mb/google/poppy/variants/atlas: Add bus_speed for audio components ......................................................................
Abandoned
Furquan changed the default i2c setting to fast speed in max98373 driver