Change in coreboot[master]: sb/intel/i82801gx: Use common AHCI

[Patrick Rudolph (Code Review)]

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37142 )

Change subject: sb/intel/i82801gx: Use common AHCI
......................................................................

sb/intel/i82801gx: Use common AHCI

Untested.

Change-Id: I836b43b515545b57eec88bf330da08fdca2902c4
Signed-off-by: Patrick Rudolph 
---
M src/southbridge/intel/i82801gx/Kconfig
M src/southbridge/intel/i82801gx/sata.c
2 files changed, 4 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/37142/1

diff --git a/src/southbridge/intel/i82801gx/Kconfig b/src/southbridge/intel/i82801gx/Kconfig
index 2d95fc2..b8f8731 100644
--- a/src/southbridge/intel/i82801gx/Kconfig
+++ b/src/southbridge/intel/i82801gx/Kconfig
@@ -20,6 +20,7 @@
    select USE_WATCHDOG_ON_BOOT
    select HAVE_SMI_HANDLER
    select COMMON_FADT
+	select SOUTHBRIDGE_INTEL_COMMON_AHCI
    select SOUTHBRIDGE_INTEL_COMMON_GPIO
    select SOUTHBRIDGE_INTEL_COMMON_SMBUS
    select SOUTHBRIDGE_INTEL_COMMON_SPI if BOOT_DEVICE_SPI_FLASH
diff --git a/src/southbridge/intel/i82801gx/sata.c b/src/southbridge/intel/i82801gx/sata.c
index 47c35ba..f902013 100644
--- a/src/southbridge/intel/i82801gx/sata.c
+++ b/src/southbridge/intel/i82801gx/sata.c
@@ -20,6 +20,8 @@
 #include <device/pci.h>
 #include <device/pci_ops.h>
 #include <device/pci_ids.h>
+#include <southbridge/intel/common/ahci.h>
+
 #include "chip.h"
 #include "i82801gx.h"
 #include "sata.h"
@@ -154,11 +156,7 @@
    	/* Interrupt Pin is set by D31IP.PIP */
    	pci_write_config8(dev, INTR_LN, 0x0a);

-		struct resource *ahci_res = find_resource(dev, PCI_BASE_ADDRESS_5);
-		if (ahci_res != NULL)
-			/* write AHCI GHC_PI register */
-			write32(res2mmio(ahci_res, 0xc, 0),
-				config->sata_ports_implemented);
+		sb_ahci_init(dev, config->sata_ports_implemented, false, false, 0, false, 0);
    	break;
    default:
    case SATA_MODE_IDE_PLAIN:

[Stefan Reinauer (Code Review)]

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37142 )

Change subject: sb/intel/i82801gx: Use common AHCI
......................................................................

Patch Set 2:

Were you able to test the common AHCI code on all these platforms?

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37142 )

Change subject: sb/intel/i82801gx: Use common AHCI
......................................................................

Patch Set 3: Code-Review+1

I can't test this, ICH7 desktops do not support AHCI mode... People with ICH7M (on i945 laptops) can test this properly, though.

[XS] Change in coreboot[master]: sb/intel/i82801gx: Use common AHCI

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37142?usp=email )

Change subject: sb/intel/i82801gx: Use common AHCI
......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.