Attention is currently required from: Julius Werner, Krishna P Bhat D. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59685 )
Change subject: soc/intel/common: Add support for CSE IOM/NPHY sub-parition update ......................................................................
Patch Set 16: Code-Review+2
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59685/comment/969333d9_f76cffc1 PS16, Line 15: 1. nit: space after `1. `
https://review.coreboot.org/c/coreboot/+/59685/comment/c56e05cf_33e36423 PS16, Line 20: 2. nit: space after `2. `
https://review.coreboot.org/c/coreboot/+/59685/comment/6828421d_8ff5da99 PS16, Line 25: 1.coreboot will navigate through the CSE region, : identify the CSE’s NPHY FW version and BIOS NPHY version. : 2.Compare both versions, if there is a difference, CSE will trigger an : NPHY FW update. Otherwise, skips the NPHY FW update. : : IOM Update: : 1.coreboot will navigate through the CSE region, identify CSE's IOM : FW version and BIOS IOM version. : 2.Compares both versions, if there is a difference, coreboot will : trigger an IOM FW update.Otherwise, skip IOM FW update. same here, spaces after `1. `, etc.
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/59685/comment/1d27b1dc_2edb68e6 PS16, Line 405: : __weak bool skip_cse_sub_part_update(void) : { : return false; : } nit; I don't think this weak function definition is still required.