Attention is currently required from: Eric Lai, Erik van den Bogaert, Felix Singer, Frans Hendriks, Jonathon Hall, Michał Żygowski, Piotr Król.
Hello Eric Lai, Erik van den Bogaert, Frans Hendriks, Jonathon Hall, Michał Żygowski, Piotr Król, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75888?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed: Code-Review+1 by Erik van den Bogaert, Code-Review+1 by Jonathon Hall, Code-Review+2 by Eric Lai, Code-Review+2 by Frans Hendriks, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: mb/{skl,kbl}: Use true/false keywords for non-array dt options ......................................................................
mb/{skl,kbl}: Use true/false keywords for non-array dt options
The true/false keywords give the reader a better understanding about how the option should be used and what it does. Thus, replace 0/1 value assignments with false/true for non-array options.
While on it, remove the quotes from the option name and from the value.
Array options are not covered by this patch since there are two different syntaxes for value assignments and it's not easy to cover both in the same script below. It might even need manual intervention. Thus, they are left out and will be handled in a follow-up patch since this patch aims to be reproducible.
The devicetrees of Skylake and Kabylake mainboards were adjusted by the following script ran from the top level directory. The script is written in a generic way so that it can be reused for other SoCs as well.
soc_gen="skylake" && \ options=`grep -A 1337 -r "struct soc_intel_${soc_gen}_config" "src/soc/intel/${soc_gen}/chip.h" | \ grep "bool" | \ cut -d ';' -f 1 | \ tr '\t' ' ' | \ cut -d ' ' -f 3 | \ sed -E 's/[a-zA-Z0-9_]+[.+]//g'` devicetrees=`find "src/mainboard" -name '*.cb' \ -exec grep -H "chip soc/intel/${soc_gen}" {} ; | \ cut -d ':' -f 1` && \ for option in ${options}; do \ echo ${devicetrees} | \ xargs sed -i'' -E \ -e "s/"${option}"(\s+)=(\s+)"1"/${option}\1=\2true/g" \ -e "s/"${option}"(\s+)=(\s+)"0"/${option}\1=\2false/g"; \ done
To get the list of devicetree options, it looks up the line containing the start of the struct defining available options and starts from there, since the more recent Intel SoCs also have other code in that file which gives false-positives. However, option names are filtered by looking for the bool keyword and removing superfluous characters. The sed command removes the arrays from the list.
Then, the script just iterates over all options and applies the sed command doing the actual adjustment to all found devicetrees related to that SoC. The regular expressions retain the spaces and tabs to keep the style that is used, which makes this patch reproducible.
Change-Id: Iff063c37a093e597c6b73a583903ce5e4f698856 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/51nb/x210/devicetree.cb M src/mainboard/acer/aspire_vn7_572g/devicetree.cb M src/mainboard/asrock/h110m/devicetree.cb M src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb M src/mainboard/facebook/monolith/devicetree.cb M src/mainboard/google/eve/devicetree.cb M src/mainboard/google/fizz/variants/baseboard/devicetree.cb M src/mainboard/google/glados/devicetree.cb M src/mainboard/google/glados/variants/caroline/overridetree.cb M src/mainboard/google/poppy/variants/atlas/devicetree.cb M src/mainboard/google/poppy/variants/baseboard/devicetree.cb M src/mainboard/google/poppy/variants/nami/devicetree.cb M src/mainboard/google/poppy/variants/nautilus/devicetree.cb M src/mainboard/google/poppy/variants/nocturne/devicetree.cb M src/mainboard/google/poppy/variants/rammus/devicetree.cb M src/mainboard/google/poppy/variants/soraka/devicetree.cb M src/mainboard/hp/280_g2/devicetree.cb M src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb M src/mainboard/intel/kblrvp/variants/rvp11/overridetree.cb M src/mainboard/intel/kblrvp/variants/rvp3/overridetree.cb M src/mainboard/intel/kblrvp/variants/rvp7/overridetree.cb M src/mainboard/intel/kblrvp/variants/rvp8/overridetree.cb M src/mainboard/intel/kunimitsu/devicetree.cb M src/mainboard/intel/saddlebrook/devicetree.cb M src/mainboard/kontron/bsl6/devicetree.cb M src/mainboard/kontron/bsl6/variants/boxer26/overridetree.cb M src/mainboard/libretrend/lt1000/devicetree.cb M src/mainboard/protectli/vault_kbl/devicetree.cb M src/mainboard/purism/librem_skl/devicetree.cb M src/mainboard/razer/blade_stealth_kbl/devicetree.cb M src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb M src/mainboard/supermicro/x11-lga1151-series/devicetree.cb M src/mainboard/system76/kbl-u/devicetree.cb 33 files changed, 230 insertions(+), 230 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/75888/5