Change in coreboot[master]: mb/google/deltaur: Enable Cirque touchpad

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

EricR Lai (Code Review)

3 Apr 2020 3 Apr '20

5:51 a.m.

EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40114 )

Change subject: mb/google/deltaur: Enable Cirque touchpad ......................................................................

mb/google/deltaur: Enable Cirque touchpad

Reference Arcada to add device tree for Cirque touchpad.

BUG=b:152931802

Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ia354702c8054b5826d45896f7bff268335726028 --- M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40114/1

diff --git a/src/mainboard/google/deltaur/variants/deltan/overridetree.cb b/src/mainboard/google/deltaur/variants/deltan/overridetree.cb index 750c3c5..b56a23b 100644 --- a/src/mainboard/google/deltaur/variants/deltan/overridetree.cb +++ b/src/mainboard/google/deltaur/variants/deltan/overridetree.cb @@ -1,5 +1,7 @@ chip soc/intel/tigerlake

+ register "pmc_gpe0_dw1" = "GPP_E" + device domain 0 on end

@@ -22,4 +24,16 @@ device i2c 34 on end end end # I2C #0 + + device pci 15.1 on + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Cirque Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_E7_IRQ)" + register "generic.probed" = "1" + register "generic.wake" = "GPE0_DW1_7" + register "hid_desc_reg_offset" = "0x20" + device i2c 2c on end + end + end # I2C #1 end

Attachments:

attachment.htm (text/html — 3.7 KB)

Show replies by date

EricR Lai (Code Review)

3 Apr 3 Apr

5:59 a.m.

Hello build bot (Jenkins), Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40114

to look at the new patch set (#2).

Change subject: mb/google/deltaur: Enable Cirque touchpad ......................................................................

mb/google/deltaur: Enable Cirque touchpad

Reference Arcada to add device tree for Cirque touchpad.

BUG=b:152931802

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40114/2

EricR Lai (Code Review)

4:44 p.m.

New subject: Change in coreboot[master]: mb/google/deltaur: Enable Cirque touchpad for Deltan

Hello Bora Guvendik, build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, Kevin Chowski,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40114

to look at the new patch set (#3).

Change subject: mb/google/deltaur: Enable Cirque touchpad for Deltan ......................................................................

mb/google/deltaur: Enable Cirque touchpad for Deltan

Reference Arcada to add device tree for Cirque touchpad.

BUG=b:152931802

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40114/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/40114 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia354702c8054b5826d45896f7bff268335726028 Gerrit-Change-Number: 40114 Gerrit-PatchSet: 3 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Kevin Chowski chowski@google.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

13 Apr 13 Apr

7:44 p.m.

New subject: Change in coreboot[master]: mb/google/deltaur: Enable Cirque touchpad for Deltan

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40114 )

Change subject: mb/google/deltaur: Enable Cirque touchpad for Deltan ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40114/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40114/2//COMMIT_MSG@7 PS2, Line 7: touchpad for Deltan

https://review.coreboot.org/c/coreboot/+/40114/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40114/2/src/mainboard/google/deltau... PS2, Line 3: register "pmc_gpe0_dw1" = "GPP_E" I would prefer the GPE settings go into the baseboard devicetree, they should hopefully be identical between the variants...

-- To view, visit https://review.coreboot.org/c/coreboot/+/40114 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia354702c8054b5826d45896f7bff268335726028 Gerrit-Change-Number: 40114 Gerrit-PatchSet: 4 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Kevin Chowski chowski@google.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 13 Apr 2020 19:44:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

EricR Lai (Code Review)

14 Apr 14 Apr

2:11 a.m.

New subject: Change in coreboot[master]: mb/google/deltaur: Enable Cirque touchpad for Deltan

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40114 )

Change subject: mb/google/deltaur: Enable Cirque touchpad for Deltan ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40114/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40114/2//COMMIT_MSG@7 PS2, Line 7: touchpad

...

for Deltan

Done

https://review.coreboot.org/c/coreboot/+/40114/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40114/2/src/mainboard/google/deltau... PS2, Line 3: register "pmc_gpe0_dw1" = "GPP_E"

...

I would prefer the GPE settings go into the baseboard devicetree, they should hopefully be identical […]

will do

-- To view, visit https://review.coreboot.org/c/coreboot/+/40114 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia354702c8054b5826d45896f7bff268335726028 Gerrit-Change-Number: 40114 Gerrit-PatchSet: 4 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Kevin Chowski chowski@google.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 14 Apr 2020 02:11:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

EricR Lai (Code Review)

2:19 a.m.

New subject: Change in coreboot[master]: mb/google/deltaur: Enable Cirque touchpad for Deltan

Hello Bora Guvendik, build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, Kevin Chowski,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40114

to look at the new patch set (#5).

Change subject: mb/google/deltaur: Enable Cirque touchpad for Deltan ......................................................................

mb/google/deltaur: Enable Cirque touchpad for Deltan

Reference Arcada to add device tree for Cirque touchpad.

BUG=b:152931802

Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ia354702c8054b5826d45896f7bff268335726028 --- M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 2 files changed, 13 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40114/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/40114 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia354702c8054b5826d45896f7bff268335726028 Gerrit-Change-Number: 40114 Gerrit-PatchSet: 5 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Kevin Chowski chowski@google.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

EricR Lai (Code Review)

2:21 a.m.

New subject: Change in coreboot[master]: mb/google/deltaur: Enable Cirque touchpad for Deltan

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40114 )

Change subject: mb/google/deltaur: Enable Cirque touchpad for Deltan ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40114/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40114/2/src/mainboard/google/deltau... PS2, Line 3: register "pmc_gpe0_dw1" = "GPP_E"

...

will do

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/40114 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia354702c8054b5826d45896f7bff268335726028 Gerrit-Change-Number: 40114 Gerrit-PatchSet: 5 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Kevin Chowski chowski@google.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 14 Apr 2020 02:21:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

3:20 p.m.

New subject: Change in coreboot[master]: mb/google/deltaur: Enable Cirque touchpad for Deltan

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40114 )

Change subject: mb/google/deltaur: Enable Cirque touchpad for Deltan ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40114 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia354702c8054b5826d45896f7bff268335726028 Gerrit-Change-Number: 40114 Gerrit-PatchSet: 5 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Kevin Chowski chowski@google.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 14 Apr 2020 15:20:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

20 Apr 20 Apr

6:03 a.m.

New subject: Change in coreboot[master]: mb/google/deltaur: Enable Cirque touchpad for Deltan

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40114 )

Change subject: mb/google/deltaur: Enable Cirque touchpad for Deltan ......................................................................

mb/google/deltaur: Enable Cirque touchpad for Deltan

Reference Arcada to add device tree for Cirque touchpad.

BUG=b:152931802

Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ia354702c8054b5826d45896f7bff268335726028 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40114 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 2 files changed, 13 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb index a30c12d..e0b3d50 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb @@ -11,7 +11,7 @@

# TODO: Figure out GPE DW1&2 register "pmc_gpe0_dw0" = "GPP_C" - #register "pmc_gpe0_dw1" = "??" + register "pmc_gpe0_dw1" = "GPP_E" #register "pmc_gpe0_dw2" = "??"

# Wilco EC host command ranges diff --git a/src/mainboard/google/deltaur/variants/deltan/overridetree.cb b/src/mainboard/google/deltaur/variants/deltan/overridetree.cb index be1f29f..13883d1 100644 --- a/src/mainboard/google/deltaur/variants/deltan/overridetree.cb +++ b/src/mainboard/google/deltaur/variants/deltan/overridetree.cb @@ -28,4 +28,16 @@ device i2c 34 on end end end # I2C #0 + + device pci 15.1 on + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Cirque Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_E7_IRQ)" + register "generic.probed" = "1" + register "generic.wake" = "GPE0_DW1_07" + register "hid_desc_reg_offset" = "0x20" + device i2c 2c on end + end + end # I2C #1 end

-- To view, visit https://review.coreboot.org/c/coreboot/+/40114 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia354702c8054b5826d45896f7bff268335726028 Gerrit-Change-Number: 40114 Gerrit-PatchSet: 6 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Kevin Chowski chowski@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1624

days inactive

1641

days old

coreboot-gerrit@coreboot.org

8 comments

3 participants

tags (0)

participants (3)

EricR Lai (Code Review)
Patrick Georgi (Code Review)
Tim Wawrzynczak (Code Review)