Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36237 )
Change subject: cpu/x86/mtrr.h: Add some bootblock guards on CPUs lacking non-evict ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/36237/1/src/include/cpu/x86/mtrr.h File src/include/cpu/x86/mtrr.h:
https://review.coreboot.org/c/coreboot/+/36237/1/src/include/cpu/x86/mtrr.h@... PS1, Line 197: !CONFIG(NO_FIXED_XIP_ROM_SIZE) This is not good... You'd want a Kconfig option to know if the CPU has a non-eviction mode. Maybe it's easier to put it in the CAR setup instead of introducing yet another Kconfig symbol.