Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
Zhaoqing Jiu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86017?usp=email )
Change subject: soc/mediatek/mt8196: Add thermal driver
......................................................................
Patch Set 3:
(2 comments)
File src/soc/mediatek/mt8196/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/86017/comment/b39732ba_3f3333ca?usp... :
PS2, Line 46: romstage-y += pmif_spmi.c
: romstage-y += srclken_rc.c
: romstage-y += mt_thermal.c
: romstage-y += mt_thermal_sram_init.c
sort
Done
File src/soc/mediatek/mt8196/mt_thermal_sram_init.c:
https://review.coreboot.org/c/coreboot/+/86017/comment/dba75a4c_0da4c756?usp... :
PS2, Line 48: int i = 0;
: uint32_t pattern = 0xffffffff;
: uint32_t *buff = (uint32_t *)GPU_THERMAL_STAT_SRAM_BASE;
: for (i = 0; i < GPU_THERMAL_STAT_SRAM_LEN / 4; i++) {
: *buff = pattern;
: buff++;
: }
Just keep it same as thermal_stat_cls_sram()
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86017?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieef94a6909e4da82461351bcb9292e9d01db3362
Gerrit-Change-Number: 86017
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Zhaoqing Jiu
zhaoqing.jiu@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Fri, 17 Jan 2025 11:08:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zhaoqing Jiu
zhaoqing.jiu@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com