Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45952 )
Change subject: soc/intel/common: add Kconfig to enable/disable the ACPI PM timer
......................................................................
Patch Set 20:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45952/17/src/soc/intel/common/block...
File src/soc/intel/common/block/pmc/Kconfig:
https://review.coreboot.org/c/coreboot/+/45952/17/src/soc/intel/common/block...
PS17, Line 45: TCO
Sorry for overlooking this. […]
"This timer is required for ACPI and for total cost of ownership (TCO),
[...]". IMO, that would hurt, badly. Explaining why the TCO block is
named TCO is really out of scope, and without explanation it's more
than confusing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45952
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f607f277eb14f84a7370ffb25a13226e7ccc917
Gerrit-Change-Number: 45952
Gerrit-PatchSet: 20
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 17 Oct 2020 22:16:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment