Attention is currently required from: Patrick Rudolph, Richard Hughes, Angel Pons, Nicholas Chin.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68995 )
Change subject: Documentation/sbom: Add SBOM Documentation ......................................................................
Patch Set 7:
(10 comments)
File Documentation/sbom/sbom.md:
https://review.coreboot.org/c/coreboot/+/68995/comment/43fd6e53_7cfb0799 PS6, Line 2: simply
nit: omit "simply"
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/953d403a_00c5cbea PS6, Line 4: much
"many", because "software parts" is countable […]
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/5f0a84ff_a0623cb5 PS6, Line 12: Systems
Why is "Systems" capitalized?
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/74719ee0_4b8ee087 PS6, Line 18: Image
Why is "Image" capitalized?
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/23ded66d_1caedab8 PS6, Line 92: CONFIG_SBOM_[software-name]_PATH
You may want to wrap this in backticks ` so that Markdown doesn't try to do anything weird. […]
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/665103ac_d22f1482 PS6, Line 103: CONFIG_SBOM_[software-name]_PATH=/path/to/me.bin
You may want to wrap this in backticks ` so that Markdown doesn't try to do anything weird. […]
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/3c28c0a3_8ba65dd1 PS6, Line 116: The second solution should in general be preferred
Why not place the preferred option first?
Done
https://review.coreboot.org/c/coreboot/+/68995/comment/8dd0fc13_e04ee2ef PS6, Line 116: The second solution should in general be preferred
Why not place the preferred option first?
Done
File Documentation/sbom/sbom_generation.plantuml:
PS6:
It appears to be the source for the diagram, written for a tool called plantuml. […]
Yes plantuml is used to generate the SVG/PNG Image file. It was easier and faster to use plantuml and if the diagram should be changed in the future one can easily use the plantuml file as basis
File Documentation/sbom/sbom_generation.png:
PS3:
@Max: Given that this is a diagram, can you please make it a SVG? […]
Done
-
Maximilian Brune (Code Review)