Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57858 )
Change subject: cpu/x86/mp_init: Add comment to smm_do_relocation ......................................................................
cpu/x86/mp_init: Add comment to smm_do_relocation
It took me a while to understand the SMM set up flow. This adds a clarifying comment.
BUG=b:194391185, b:179699789 TEST=None
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I9c73e416b8c583cf870e7a29b0bd7dcc99c2f5f4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/57858 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Paul Menzel paulepanter@mailbox.org --- M src/cpu/x86/mp_init.c 1 file changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved
diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index aa037f3..f54a7b7 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -714,6 +714,11 @@ mp_state.do_smm = 1; }
+/* + * This code is built as part of ramstage, but it actually runs in SMM. This + * means that ENV_SMM is 0, but we are actually executing in the environment + * setup by the smm_stub. + */ static void asmlinkage smm_do_relocation(void *arg) { const struct smm_module_params *p;
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.