Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31928 )
Change subject: soc/intel/cannonlake: enable VMX support
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31928/4/src/soc/intel/cannonlake/cpu.c
File src/soc/intel/cannonlake/cpu.c:
https://review.coreboot.org/#/c/31928/4/src/soc/intel/cannonlake/cpu.c@410
PS4, Line 410: VmxEnable is set and VtdDisable
It will not configure Vmx as per CB:25118 Vmx should be disabled if Vtd Disabled is set.
I asked there, too and didn't get an answer so far. Why disable VT-x
if VT-d is disabled? Usually those work independently.
Also, why would we want to disable VT-d at all?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31928
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33dbffa6301afabd688080751ba3b85a43e00156
Gerrit-Change-Number: 31928
Gerrit-PatchSet: 5
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: RONAK KANABAR
ronak199323@gmail.com
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Fri, 29 Mar 2019 17:25:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ronak Kanabar
ronak.kanabar@intel.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment