Change in coreboot[master]: Kconfig: Have GDB_STUB depend on DRIVERS_UART

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Arthur Heymans (Code Review)

4 Nov 2019 4 Nov '19

5:35 a.m.

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36604 )

Change subject: Kconfig: Have GDB_STUB depend on DRIVERS_UART ......................................................................

Kconfig: Have GDB_STUB depend on DRIVERS_UART

There is no reason to hide the GDB_STUB option when SERIAL_CONSOLE is set.

Change-Id: Icbf9a1ac0e617939cafa3d66774bbd467dc01cbc Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/36604/1

diff --git a/src/Kconfig b/src/Kconfig index 793927a..ad6c18a 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -746,7 +746,7 @@ config GDB_STUB bool "GDB debugging support" default n - depends on CONSOLE_SERIAL + depends on DRIVERS_UART help If enabled, you will be able to set breakpoints for gdb debugging. See src/arch/x86/lib/c_start.S for details.

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by date

Kyösti Mälkki (Code Review)

4 Nov 4 Nov

7:15 a.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36604 )

Change subject: Kconfig: Have GDB_STUB depend on DRIVERS_UART ......................................................................

Patch Set 1:

include/console/uart.h __CONSOLE_SERIAL_ENABLE__ has to be adjusted too to make it actually work.

Arthur Heymans (Code Review)

7:35 a.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36604 )

Change subject: Kconfig: Have GDB_STUB depend on DRIVERS_UART ......................................................................

Patch Set 1:

...

Patch Set 1:

include/console/uart.h __CONSOLE_SERIAL_ENABLE__ has to be adjusted too to make it actually work.

Is that so? The GDB stub has it's own callbacks for that it seems? __gdb_hw_init __gdb_tx_byte ...

-- To view, visit https://review.coreboot.org/c/coreboot/+/36604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbf9a1ac0e617939cafa3d66774bbd467dc01cbc Gerrit-Change-Number: 36604 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Mon, 04 Nov 2019 10:35:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

8:49 a.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36604 )

Change subject: Kconfig: Have GDB_STUB depend on DRIVERS_UART ......................................................................

Patch Set 1: Code-Review+1

...

Patch Set 1:

...
Patch Set 1:

include/console/uart.h __CONSOLE_SERIAL_ENABLE__ has to be adjusted too to make it actually work.

Is that so? The GDB stub has it's own callbacks for that it seems? __gdb_hw_init __gdb_tx_byte ...

Ah.. I was fooled by the underscores.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbf9a1ac0e617939cafa3d66774bbd467dc01cbc Gerrit-Change-Number: 36604 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 Nov 2019 11:49:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

10:24 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36604 )

Change subject: Kconfig: Have GDB_STUB depend on DRIVERS_UART ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbf9a1ac0e617939cafa3d66774bbd467dc01cbc Gerrit-Change-Number: 36604 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 Nov 2019 13:24:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

10:25 a.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36604 )

Change subject: Kconfig: Have GDB_STUB depend on DRIVERS_UART ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36604/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/36604/1//COMMIT_MSG@10 PS1, Line 10: set. is not set ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbf9a1ac0e617939cafa3d66774bbd467dc01cbc Gerrit-Change-Number: 36604 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 Nov 2019 13:25:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

3 Mar 3 Mar

4:44 a.m.

Patrick Georgi has uploaded a new patch set (#2) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/36604 )

Change subject: Kconfig: Have GDB_STUB depend on DRIVERS_UART ......................................................................

Kconfig: Have GDB_STUB depend on DRIVERS_UART

There is no reason to hide the GDB_STUB option when CONSOLE_SERIAL is not set.

Change-Id: Icbf9a1ac0e617939cafa3d66774bbd467dc01cbc Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/36604/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbf9a1ac0e617939cafa3d66774bbd467dc01cbc Gerrit-Change-Number: 36604 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

4:45 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36604 )

Change subject: Kconfig: Have GDB_STUB depend on DRIVERS_UART ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36604/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/36604/1//COMMIT_MSG@10 PS1, Line 10: set.

...

is not set ?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/36604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbf9a1ac0e617939cafa3d66774bbd467dc01cbc Gerrit-Change-Number: 36604 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 03 Mar 2020 07:45:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4:45 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36604 )

Change subject: Kconfig: Have GDB_STUB depend on DRIVERS_UART ......................................................................

Kconfig: Have GDB_STUB depend on DRIVERS_UART

There is no reason to hide the GDB_STUB option when CONSOLE_SERIAL is not set.

Change-Id: Icbf9a1ac0e617939cafa3d66774bbd467dc01cbc Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36604 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de --- M src/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Nico Huber: Looks good to me, approved

diff --git a/src/Kconfig b/src/Kconfig index 16bc4ab..d92bfd6 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -764,7 +764,7 @@ config GDB_STUB bool "GDB debugging support" default n - depends on CONSOLE_SERIAL + depends on DRIVERS_UART help If enabled, you will be able to set breakpoints for gdb debugging. See src/arch/x86/lib/c_start.S for details.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbf9a1ac0e617939cafa3d66774bbd467dc01cbc Gerrit-Change-Number: 36604 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

4:55 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36604 )

Change subject: Kconfig: Have GDB_STUB depend on DRIVERS_UART ......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1056 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1055 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1054

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/36604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbf9a1ac0e617939cafa3d66774bbd467dc01cbc Gerrit-Change-Number: 36604 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 03 Mar 2020 07:55:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1578

days inactive

1698

days old

coreboot-gerrit@coreboot.org

9 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Arthur Heymans (Code Review)
Kyösti Mälkki (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)