Change in coreboot[master]: soc/intel/xeon_sp: Add Lewisburg defs for common/gpio driver
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39425 )
Change subject: soc/intel/xeon_sp: Add Lewisburg defs for common/gpio driver ......................................................................
Patch Set 15:
(5 comments)
Thanks so much to everyone for review and testing :)
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/acpi... File src/soc/intel/xeon_sp/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/acpi... PS11, Line 5: define
This file was removed from the change. Marking as resolved.
These macros are used only here, but I would like to put this in any of the *.h files to make apci code more clean.
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/acpi... PS11, Line 27: /* GPIO Community 0 */ : CreateDWordField (^RBUF, ^COM0._BAS, BAS0) : CreateDWordField (^RBUF, ^COM0._LEN, LEN0) :
This file was removed from the change. Marking as resolved.
At the moment, acpi still needs a lot of changes, so I moved this to the commit commit: https://review.coreboot.org/c/coreboot/+/39979
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/acpi... PS11, Line 37: GPIO_BASE_SIZE
This file was removed from the change. Marking as resolved.
At the moment, acpi still needs a lot of changes, so I moved this to the commit commit: https://review.coreboot.org/c/coreboot/+/39979
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/acpi... PS11, Line 88: Subtract
Please use the new asl syntax where possible
Done in https://review.coreboot.org/c/coreboot/+/39979/1..2
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/incl... File src/soc/intel/xeon_sp/include/soc/lewisburg_pch_gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/incl... PS11, Line 340: ALIGN_UP
*poke*
In my case, that's not possible, because the macro DIV_ROUND_UP contains {}
#define DIV_ROUND_UP(x, y) ({ \ typeof(x) _div_local_x = (x); \ typeof(y) _div_local_y = (y); \ (_div_local_x + _div_local_y - 1) / _div_local_y; \ })
-
Maxim Polyakov (Code Review)