Attention is currently required from: Lance Zhao, Subrata Banik, Caveh Jalali, Reka Norman, Tim Wawrzynczak, Sumeet R Pawnikar, Boris Mittelberg.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73249 )
Change subject: Reland drivers/intel/dptf: Add multiple fan support under dptf ......................................................................
Patch Set 3:
(12 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73249/comment/c266ee14_36d8106c PS3, Line 13: Gmeet Please use Google Meet.
https://review.coreboot.org/c/coreboot/+/73249/comment/da780c3a_13c357f4 PS3, Line 15: as per the expectation as expected
https://review.coreboot.org/c/coreboot/+/73249/comment/707e83ff_00e7119a PS3, Line 16: observed is observed
https://review.coreboot.org/c/coreboot/+/73249/comment/39b706df_cbbdc8bb PS3, Line 16: the an
https://review.coreboot.org/c/coreboot/+/73249/comment/97482ebb_0d8e6334 PS3, Line 18: AlderLake Alder Lake
https://review.coreboot.org/c/coreboot/+/73249/comment/0bc82bb1_a0d33314 PS3, Line 18: observed is observed
https://review.coreboot.org/c/coreboot/+/73249/comment/33218800_5a82c1f8 PS3, Line 22: Thank you for the detailed problem description. Please also describe the implementation as you adapted several components.
https://review.coreboot.org/c/coreboot/+/73249/comment/f8340e90_89f78f8b PS3, Line 25: Alderlake Ditto.
https://review.coreboot.org/c/coreboot/+/73249/comment/ea0f1238_5d24b112 PS3, Line 26: Alderlake Ditto.
File src/include/acpi/acpigen_dptf.h:
https://review.coreboot.org/c/coreboot/+/73249/comment/b3568c2a_fe005a04 PS3, Line 128: speed Please append the unit: speed_rpm.
https://review.coreboot.org/c/coreboot/+/73249/comment/5582eb12_f0e31865 PS3, Line 130: noise_level Ditto.
https://review.coreboot.org/c/coreboot/+/73249/comment/e74a4ef7_48ced9f3 PS3, Line 132: power Ditto.