Change in coreboot[master]: mb/google/dedede: Add Goodix touchscreen

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: HACK...

Evan Green (Code Review)

6 Jul 2020 6 Jul '20

11:35 p.m.

Evan Green has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

mb/google/dedede: Add Goodix touchscreen

Add overridetree info for the touchscreen, and make a define for TOUCH_INT_ODL since everyone else seems to do that.

BUG=b:160129126 TEST=cros flash-ap -b dedede

Signed-off-by: Evan Green evgreen@chromium.org Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 --- M src/mainboard/google/dedede/variants/waddledee/include/variant/gpio.h M src/mainboard/google/dedede/variants/waddledee/overridetree.cb 2 files changed, 19 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/43153/1

diff --git a/src/mainboard/google/dedede/variants/waddledee/include/variant/gpio.h b/src/mainboard/google/dedede/variants/waddledee/include/variant/gpio.h index c7e4605..dabefeb 100644 --- a/src/mainboard/google/dedede/variants/waddledee/include/variant/gpio.h +++ b/src/mainboard/google/dedede/variants/waddledee/include/variant/gpio.h @@ -9,4 +9,6 @@

#include <baseboard/gpio.h>

+#define TOUCH_INT_ODL GPP_D4_IRQ + #endif /* MAINBOARD_GPIO_H */ diff --git a/src/mainboard/google/dedede/variants/waddledee/overridetree.cb b/src/mainboard/google/dedede/variants/waddledee/overridetree.cb index 33c578c..6223165 100644 --- a/src/mainboard/google/dedede/variants/waddledee/overridetree.cb +++ b/src/mainboard/google/dedede/variants/waddledee/overridetree.cb @@ -66,5 +66,22 @@ device i2c 0x2c on end end end + device pci 15.2 on + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" + register "generic.reset_delay_ms" = "120" + register "generic.reset_off_delay_ms" = "3" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" + register "generic.enable_delay_ms" = "12" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 14 on end # TODO: Someone plz scan to see what the right value is here. + end + end end end

Attachments:

attachment.htm (text/html — 5.0 KB)

Show replies by date

Evan Green (Code Review)

6 Jul 6 Jul

11:37 p.m.

Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

Patch Set 1:

Here's an initial attempt at touchscreen. I don't have a unit yet, so there are most likely errors here.

Karthik Ramasubramanian (Code Review)

7 Jul 7 Jul

8:38 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43153/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43153/1/src/mainboard/google/dedede... PS1, Line 83: 14 It should be 5d. i2cdetect detects Touchscreen on address 0x5d.

Karthik Ramasubramanian (Code Review)

8:42 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43153/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43153/1/src/mainboard/google/dedede... PS1, Line 83: 14

...

It should be 5d. i2cdetect detects Touchscreen on address 0x5d.

Even after that observing "i2c_hid i2c-GDIX0000:00: failed to retrieve report from device." error message in kernel logs. Need to triage further.

Evan Green (Code Review)

8 Jul 8 Jul

1:53 a.m.

Hello build bot (Jenkins), Karthikeyan Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43153

to look at the new patch set (#2).

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

mb/google/dedede: Add Goodix touchscreen

Add overridetree info for the touchscreen, and make a define for TOUCH_INT_ODL since everyone else seems to do that.

BUG=b:160129126 TEST=cros flash-ap -b dedede

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/43153/2

Evan Green (Code Review)

1:54 a.m.

Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43153/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43153/1/src/mainboard/google/dedede... PS1, Line 83: 14

...

Even after that observing "i2c_hid i2c-GDIX0000:00: failed to retrieve report from device. […]

got it. I got my device today so I may be able to take a look tomorrow. Maybe it just needs a FW update first.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 2 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 07 Jul 2020 23:54:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Marco Chen (Code Review)

14 Jul 14 Jul

4:32 p.m.

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 77: 120 * T3 is >= 10ms in the spec between Reset and Report_EN? * And there is to stop_gpio (report_en) here? * Then stop_delay_ms can be 110ms

https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 78: 3 1ms for T2 and T3 in the spec so do we play safe here?

https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 80: 12 The GT7375P Programming Guide Rev 0.4 mentions that T1 (AVDD -> Reset) is >= 10 so we set to 12 for playing safe?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 2 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Marco Chen marcochen@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-CC: Yan Liu yan.liu@bitland.corp-partner.google.com Gerrit-Comment-Date: Tue, 14 Jul 2020 14:32:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Evan Green (Code Review)

16 Jul 16 Jul

12:05 a.m.

Hello build bot (Jenkins), Karthikeyan Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43153

to look at the new patch set (#3).

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

mb/google/dedede: Add Goodix touchscreen

Add overridetree info for the touchscreen, and make a define for TOUCH_INT_ODL since everyone else seems to do that.

BUG=b:160129126 TEST=cros flash-ap -b dedede

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/43153/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/43153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 3 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Marco Chen marcochen@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-CC: Yan Liu yan.liu@bitland.corp-partner.google.com Gerrit-MessageType: newpatchset

Evan Green (Code Review)

12:07 a.m.

Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 77: 120

...

T3 is >= 10ms in the spec between Reset and Report_EN? […]

There does seem to be a TOUCH_RPT_EN, so the stop_gpio should be added. Need to confirm it actually goes to the chip. Will do that.

Then T1 is 12ms, T3 is 12ms, and then stop_delay can be 110.

https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 78: 3

...

1ms for T2 and T3 in the spec so do we play safe here?

Yes, though it seems like 2 should be fine here, so I'll change to that, and add stop_off_delay_ms of 2 as well.

https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 80: 12

...

The GT7375P Programming Guide Rev 0. […]

I noticed most of the other users of GDIX0000 seem to have this padding. If we're feeling adventurous we could start with 10 and see if problems come up.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 3 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Marco Chen marcochen@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-CC: Yan Liu yan.liu@bitland.corp-partner.google.com Gerrit-Comment-Date: Wed, 15 Jul 2020 22:07:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marco Chen marcochen@google.com Gerrit-MessageType: comment

Marco Chen (Code Review)

7:59 a.m.

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

Patch Set 3: Code-Review+1

And as Evan mentioned, need to check with sub board of Goodix for Report_En pin.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 3 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-CC: Yan Liu yan.liu@bitland.corp-partner.google.com Gerrit-Comment-Date: Thu, 16 Jul 2020 05:59:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Marco Chen (Code Review)

17 Jul 17 Jul

3:47 a.m.

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 77: 120

...

There does seem to be a TOUCH_RPT_EN, so the stop_gpio should be added. […]

Partners confirmed that Report_En (stop_gpio) is not enabled in this module so we don't need to consider this stop_gpio.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 3 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-CC: Yan Liu yan.liu@bitland.corp-partner.google.com Gerrit-Comment-Date: Fri, 17 Jul 2020 01:47:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Evan Green evgreen@chromium.org Comment-In-Reply-To: Marco Chen marcochen@google.com Gerrit-MessageType: comment

Evan Green (Code Review)

5:29 p.m.

Hello build bot (Jenkins), Marco Chen, Karthikeyan Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43153

to look at the new patch set (#4).

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

mb/google/dedede: Add Goodix touchscreen

Add overridetree info for the touchscreen, and make a define for TOUCH_INT_ODL since everyone else seems to do that.

BUG=b:160129126 TEST=cros flash-ap -b dedede

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/43153/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/43153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 4 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-CC: Yan Liu yan.liu@bitland.corp-partner.google.com Gerrit-MessageType: newpatchset

Evan Green (Code Review)

5:30 p.m.

Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 77: 120

...

Partners confirmed that Report_En (stop_gpio) is not enabled in this module so we don't need to cons […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 4 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-CC: Yan Liu yan.liu@bitland.corp-partner.google.com Gerrit-Comment-Date: Fri, 17 Jul 2020 15:30:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Evan Green evgreen@chromium.org Comment-In-Reply-To: Marco Chen marcochen@google.com Gerrit-MessageType: comment

Marco Chen (Code Review)

20 Jul 20 Jul

6:35 a.m.

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 4 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-CC: Yan Liu yan.liu@bitland.corp-partner.google.com Gerrit-Comment-Date: Mon, 20 Jul 2020 04:35:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

21 Jul 21 Jul

6:52 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43153/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/include/variant/gpio.h:

https://review.coreboot.org/c/coreboot/+/43153/4/src/mainboard/google/dedede... PS4, Line 12: #define TOUCH_INT_ODL GPP_D4_IRQ I don't see it being used anywhere. Can be removed.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 4 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-CC: Yan Liu yan.liu@bitland.corp-partner.google.com Gerrit-Comment-Date: Tue, 21 Jul 2020 16:52:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Evan Green (Code Review)

8:29 p.m.

Hello build bot (Jenkins), Marco Chen, Karthikeyan Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43153

to look at the new patch set (#5).

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

mb/google/dedede: Add Goodix touchscreen

Add overridetree info for the touchscreen.

BUG=b:160129126 TEST=cros flash-ap -b dedede

Signed-off-by: Evan Green evgreen@chromium.org Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 --- M src/mainboard/google/dedede/variants/waddledee/overridetree.cb 1 file changed, 15 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/43153/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/43153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 5 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-CC: Yan Liu yan.liu@bitland.corp-partner.google.com Gerrit-MessageType: newpatchset

Evan Green (Code Review)

8:29 p.m.

Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43153/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/include/variant/gpio.h:

https://review.coreboot.org/c/coreboot/+/43153/4/src/mainboard/google/dedede... PS4, Line 12: #define TOUCH_INT_ODL GPP_D4_IRQ

...

I don't see it being used anywhere. Can be removed.

Done.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 5 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-CC: Yan Liu yan.liu@bitland.corp-partner.google.com Gerrit-Comment-Date: Tue, 21 Jul 2020 18:29:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

9:38 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 5 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-CC: Yan Liu yan.liu@bitland.corp-partner.google.com Gerrit-Comment-Date: Tue, 21 Jul 2020 19:38:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Evan Green (Code Review)

28 Jul 28 Jul

8:34 p.m.

Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

Patch Set 5:

(3 comments)

Marking comments as Done, maybe that will make the build go?

https://review.coreboot.org/c/coreboot/+/43153/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43153/1/src/mainboard/google/dedede... PS1, Line 83: 14

...

got it. I got my device today so I may be able to take a look tomorrow. […]

Done

https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 78: 3

...

Yes, though it seems like 2 should be fine here, so I'll change to that, and add stop_off_delay_ms o […]

Done

https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 80: 12

...

I noticed most of the other users of GDIX0000 seem to have this padding. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 5 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-CC: Yan Liu yan.liu@bitland.corp-partner.google.com Gerrit-Comment-Date: Tue, 28 Jul 2020 18:34:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Evan Green evgreen@chromium.org Comment-In-Reply-To: Marco Chen marcochen@google.com Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

30 Jul 30 Jul

7:26 a.m.

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

mb/google/dedede: Add Goodix touchscreen

Add overridetree info for the touchscreen.

BUG=b:160129126 TEST=cros flash-ap -b dedede

Signed-off-by: Evan Green evgreen@chromium.org Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43153 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/waddledee/overridetree.cb 1 file changed, 15 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/waddledee/overridetree.cb b/src/mainboard/google/dedede/variants/waddledee/overridetree.cb index 3534c4e3..b18e589 100644 --- a/src/mainboard/google/dedede/variants/waddledee/overridetree.cb +++ b/src/mainboard/google/dedede/variants/waddledee/overridetree.cb @@ -84,6 +84,21 @@ register "hid_desc_reg_offset" = "0x00" device i2c 5c on end end + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" + register "generic.reset_delay_ms" = "120" + register "generic.reset_off_delay_ms" = "2" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" + register "generic.enable_delay_ms" = "12" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 0x5d on end + end end # I2C 2 device pci 19.0 on chip drivers/i2c/generic

-- To view, visit https://review.coreboot.org/c/coreboot/+/43153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 6 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-CC: Yan Liu yan.liu@bitland.corp-partner.google.com Gerrit-MessageType: merged

Marco Chen (Code Review)

5:35 p.m.

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )

Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55fc0749b824a0bf4b615d02bd8bc39bcdd589e0 Gerrit-Change-Number: 43153 Gerrit-PatchSet: 6 Gerrit-Owner: Evan Green evgreen@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Marco Chen marcochen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-CC: Yan Liu yan.liu@bitland.corp-partner.google.com Gerrit-Comment-Date: Thu, 30 Jul 2020 15:35:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1559

days inactive

1583

days old

coreboot-gerrit@coreboot.org

20 comments

3 participants

tags (0)

participants (3)

Evan Green (Code Review)
Karthik Ramasubramanian (Code Review)
Marco Chen (Code Review)