Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56121 )
Change subject: arch/x86: smbios write 7 table using deterministic cache functions ......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
Do we have some more details about the brokenness, that would help to understand what might have wen […]
swiftgeek reports, the boot hangs after
``` ACPI: added table 7/32, length now 64 CBFS: Found 'pci1002,9802.rom' @0x4d6c0 size 0xe200 in mcache @0x67fdd1bc In CBFS, ROM address for PCI: 00:01.0 = 0xffc4d8ec Copying VBIOS image from 0xffc4d8ec ACPI: * VFCT at 67e5a430 ACPI: added table 8/32, length now 68 ACPI: * HPET ACPI: added table 9/32, length now 72 ACPI: done. ACPI tables: 75488 bytes. smbios_write_tables: 67e55000 SMBIOS firmware version is set to coreboot_version: '4.14-1439-g81d5a25fbb-dirty' ```
with `-dirty` coming from 3rdparty submodule pointer differences:
``` diff --git a/3rdparty/arm-trusted-firmware b/3rdparty/arm-trusted-firmware index 586aafa3a4..7ad39818b1 160000 --- a/3rdparty/arm-trusted-firmware +++ b/3rdparty/arm-trusted-firmware @@ -1 +1 @@ -Subproject commit 586aafa3a4b13971339f78e430075592c3fe74b5 +Subproject commit 7ad39818b184850d263008e7d36ba16adf72a669 diff --git a/3rdparty/blobs b/3rdparty/blobs index f388b6794e..fc2d4e2587 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit f388b6794e6f1f93b847de353f5eab8ba3e3b328 +Subproject commit fc2d4e2587e1260f4fe4114e797541229bcc6b9e diff --git a/3rdparty/chromeec b/3rdparty/chromeec index 4c21b57eb9..1e800ac838 160000 --- a/3rdparty/chromeec +++ b/3rdparty/chromeec @@ -1 +1 @@ -Subproject commit 4c21b57eb9619cc3dc86d11226917d25f62f1bc8 +Subproject commit 1e800ac838504c0d2950c7aa90cdfe7bde251545 diff --git a/3rdparty/intel-microcode b/3rdparty/intel-microcode index 3f97690f0d..49bb67f32a 160000 --- a/3rdparty/intel-microcode +++ b/3rdparty/intel-microcode @@ -1 +1 @@ -Subproject commit 3f97690f0da8011f52209b232450a1e5c4f2e1f6 +Subproject commit 49bb67f32a2e3e631ba1a9a73da1c52e1cac7fd9 diff --git a/3rdparty/intel-sec-tools b/3rdparty/intel-sec-tools index 0031ac7344..a86ff5d400 160000 --- a/3rdparty/intel-sec-tools +++ b/3rdparty/intel-sec-tools @@ -1 +1 @@ -Subproject commit 0031ac73447baeb197fb2d80e5fba2470716e76d +Subproject commit a86ff5d400983d685d4389c07433452c7a503300 diff --git a/3rdparty/libgfxinit b/3rdparty/libgfxinit index 1b04c517b3..bc0588e482 160000 --- a/3rdparty/libgfxinit +++ b/3rdparty/libgfxinit @@ -1 +1 @@ -Subproject commit 1b04c517b377468b3b470d38607fb539187391dd +Subproject commit bc0588e482b1320d5739900b00a45033f5b587f4 diff --git a/3rdparty/libhwbase b/3rdparty/libhwbase index fc2102f560..a3edc6ef32 160000 --- a/3rdparty/libhwbase +++ b/3rdparty/libhwbase @@ -1 +1 @@ -Subproject commit fc2102f560f25e0f2e5be91ec36646dcb69e6e1b +Subproject commit a3edc6ef32d09c566b7ea3555bc753458ec63039 diff --git a/3rdparty/vboot b/3rdparty/vboot index ccc56f46c5..48195e5878 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit ccc56f46c51fa9d0c2b3c086ace97c14fe887c32 +Subproject commit 48195e5878006ac2cf74cb7f02953ab06c68202d diff --git a/util/nvidia/cbootimage b/util/nvidia/cbootimage --- a/util/nvidia/cbootimage +++ b/util/nvidia/cbootimage @@ -1 +1 @@ -Subproject commit 65a6d94dd5f442578551e0a81ecbe5235e673fd4 +Subproject commit 65a6d94dd5f442578551e0a81ecbe5235e673fd4-dirty ```