Attention is currently required from: Alexander Couzens, Angel Pons, Felix Held.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81597?usp=email )
Change subject: cpu/intel/model_206ax: Allow to configure VR settings
......................................................................
Patch Set 2:
(2 comments)
File src/cpu/intel/model_206ax/model_206ax_init.c:
https://review.coreboot.org/c/coreboot/+/81597/comment/b245eee2_1e95cfcc :
PS2, Line 213: BIOS_INFO
I feel these messages should be `BIOS_DEBUG`
IMHO all devicetrees should contain those value. Maybe BIOS_WARNING?
File src/mainboard/lenovo/x220/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/81597/comment/d533bf77_fa516a86 :
PS2, Line 41: 98
Where does this number come from?
As the comment above states, extracted from vendor firmware.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81597?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I59edab47fc4fbe0240e1dd7d25647f7549b4def2
Gerrit-Change-Number: 81597
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 13 Apr 2024 06:49:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment