Attention is currently required from: Jason Glenesk, Nico Huber, Raul Rangel, Marshall Dawson, Kyösti Mälkki, Felix Held.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51887 )
Change subject: [RFC] Rename do_printk() --> printk()
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51887/comment/92e32010_dfa5c6bc
PS2, Line 9: The indirection seems unnecessary. The macros throw features like
The indirection has historical roots: back in the day it was possible to compile out log levels and that was done in the printk (et al) macros, either forwarding to do_printk or removing the statement entirely. Since we now keep all strings all the time, the indirection can go away.
Patchset:
PS2:
Maybe drop the "[RFC]", but then it can go in ;-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51887
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4eab935a367b5ad6b38225c4973d41d9f70ef10
Gerrit-Change-Number: 51887
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 06 Apr 2021 07:15:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment