Change in coreboot[master]: soc/intel/xeon_sp/cpx: Advertise PM timer

[Patrick Rudolph (Code Review)]

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46848 )

Change subject: soc/intel/xeon_sp/cpx: Advertise PM timer
......................................................................

soc/intel/xeon_sp/cpx: Advertise PM timer

Unclear why it was missing and if it's working.
Test: Tianocore now boots.

Change-Id: I7e68430c3e720561b85834c5f8c43c1c24da852f
Signed-off-by: Patrick Rudolph 
---
M src/soc/intel/xeon_sp/cpx/acpi.c
1 file changed, 8 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/46848/1

diff --git a/src/soc/intel/xeon_sp/cpx/acpi.c b/src/soc/intel/xeon_sp/cpx/acpi.c
index 3066dda2..a4a3fc3 100644
--- a/src/soc/intel/xeon_sp/cpx/acpi.c
+++ b/src/soc/intel/xeon_sp/cpx/acpi.c
@@ -142,7 +142,7 @@

fadt->pm1a_evt_blk = pmbase + PM1_STS;
    fadt->pm1a_cnt_blk = pmbase + PM1_CNT;
-
+	fadt->pm_tmr_blk = pmbase + PM1_TMR;
    fadt->gpe0_blk = pmbase + GPE0_STS(0);

fadt->pm1_evt_len = 4;
@@ -169,6 +169,13 @@
    fadt->x_pm1a_cnt_blk.addrl = pmbase + PM1_CNT;
    fadt->x_pm1a_cnt_blk.access_size = ACPI_ACCESS_SIZE_WORD_ACCESS;

+	fadt->x_pm_tmr_blk.space_id = ACPI_ADDRESS_SPACE_IO;
+	fadt->x_pm_tmr_blk.bit_width = 32;
+	fadt->x_pm_tmr_blk.bit_offset = 0;
+	fadt->x_pm_tmr_blk.access_size = ACPI_ACCESS_SIZE_DWORD_ACCESS;
+	fadt->x_pm_tmr_blk.addrl = pmbase + PM1_TMR;
+	fadt->x_pm_tmr_blk.addrh = 0x0;
+
    /*
     * Windows 10 requires x_gpe0_blk to be set starting with FADT revision 5.
     * The bit_width field intentionally overflows here.

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46848 )

Change subject: soc/intel/xeon_sp/cpx: Advertise PM timer
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46848 )

Change subject: soc/intel/xeon_sp/cpx: Advertise PM timer
......................................................................

Patch Set 1: Code-Review+2

[Rocky Phagura (Code Review)]

Attention is currently required from: Patrick Rudolph.
Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46848 )

Change subject: soc/intel/xeon_sp/cpx: Advertise PM timer
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

Patchset:

PS1: 
This patch is ready to be merged.

[XS] Change in coreboot[master]: soc/intel/xeon_sp/cpx: Advertise PM timer

[Stefan Reinauer (Code Review)]

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46848?usp=email )

Change subject: soc/intel/xeon_sp/cpx: Advertise PM timer
......................................................................

Abandoned