Change in coreboot[master]: [UNTESTED] mb/google/zork: don't enable IRQ1/IRQ12 filter

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: zork:...

Felix Held (Code Review)

20 Jun 2020 20 Jun '20

4:20 p.m.

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42611 )

Change subject: [UNTESTED] mb/google/zork: don't enable IRQ1/IRQ12 filter ......................................................................

[UNTESTED] mb/google/zork: don't enable IRQ1/IRQ12 filter

Some zork devices had issues with keyboard and touchpad IRQs not being delivered under some conditions. Disabling the IRQ1/IRQ12 filter might fix this issue.

Change-Id: If646d4745454cdc1b3a0da5187a5af2d31116b90 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/google/zork/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/42611/1

diff --git a/src/mainboard/google/zork/mainboard.c b/src/mainboard/google/zork/mainboard.c index c6b4bdd..9a755d9 100644 --- a/src/mainboard/google/zork/mainboard.c +++ b/src/mainboard/google/zork/mainboard.c @@ -117,7 +117,7 @@

/* The MISC registers are not interrupt numbers */ { PIRQ_MISC, 0xfa, 0x00 }, - { PIRQ_MISC0, 0xf1, 0x00 }, + { PIRQ_MISC0, 0x91, 0x00 }, { PIRQ_MISC1, 0x00, 0x00 }, { PIRQ_MISC2, 0x00, 0x00 }, };

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Paul Menzel (Code Review)

20 Jun 20 Jun

8:35 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42611 )

Change subject: [UNTESTED] mb/google/zork: don't enable IRQ1/IRQ12 filter ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42611/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42611/1//COMMIT_MSG@12 PS1, Line 12: Is there a bug report for that? If yes, please add it as reference.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42611 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If646d4745454cdc1b3a0da5187a5af2d31116b90 Gerrit-Change-Number: 42611 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 20 Jun 2020 20:35:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Held (Code Review)

8:40 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42611 )

Change subject: [UNTESTED] mb/google/zork: don't enable IRQ1/IRQ12 filter ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42611/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42611/1//COMMIT_MSG@12 PS1, Line 12:

...

Is there a bug report for that? If yes, please add it as reference.

There is, but I don't have the bug number.

Found this possible issue when looking into the IRQ routing table of Mandolin and that correlated with an issue I heard of, but don't know the ticket number. Expecting that someone else will either take over the patch or tell me which bug number this fixes in the case that is the solution

-- To view, visit https://review.coreboot.org/c/coreboot/+/42611 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If646d4745454cdc1b3a0da5187a5af2d31116b90 Gerrit-Change-Number: 42611 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 20 Jun 2020 20:40:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Felix Held (Code Review)

23 Jul 23 Jul

2:15 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42611 )

Change subject: [UNTESTED] mb/google/zork: don't enable IRQ1/IRQ12 filter ......................................................................

Patch Set 1:

Since the cause of the issues with the keyboard/touchpad IRQs after resume was something different and I'm not 100% sure what the bits this change flips cause in the hardware, I wonder if I should keep this patch around or abandon it

-- To view, visit https://review.coreboot.org/c/coreboot/+/42611 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If646d4745454cdc1b3a0da5187a5af2d31116b90 Gerrit-Change-Number: 42611 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 23 Jul 2020 14:15:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Eric Peers (Code Review)

5:19 p.m.

Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42611 )

Change subject: [UNTESTED] mb/google/zork: don't enable IRQ1/IRQ12 filter ......................................................................

Patch Set 1: Code-Review-1

...

Patch Set 1:

Since the cause of the issues with the keyboard/touchpad IRQs after resume was something different and I'm not 100% sure what the bits this change flips cause in the hardware, I wonder if I should keep this patch around or abandon it

+1 to abandon for now. You can always dust it off later. -the CL doesn't have a bug tied to it (but I presume: b/157572621) - which was fixed by removing the double inverts on interrupts and setting to an edge interrupt vs. level https://review.coreboot.org/c/coreboot/+/43011 https://review.coreboot.org/c/coreboot/+/43010

-it's not tested

-- To view, visit https://review.coreboot.org/c/coreboot/+/42611 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If646d4745454cdc1b3a0da5187a5af2d31116b90 Gerrit-Change-Number: 42611 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 23 Jul 2020 17:19:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

6:02 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42611 )

Change subject: [UNTESTED] mb/google/zork: don't enable IRQ1/IRQ12 filter ......................................................................

Patch Set 1:

...

-the CL doesn't have a bug tied to it (but I presume: b/157572621)

that's the corresponding bug; when I found the bits this patch changes, I didn't know which bug this was related to, since I only knew the bug from the meeting and didn't find it during a quick search

...

-it's not tested

it was tested by someone else, but didn't solve the problem

-- To view, visit https://review.coreboot.org/c/coreboot/+/42611 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If646d4745454cdc1b3a0da5187a5af2d31116b90 Gerrit-Change-Number: 42611 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 23 Jul 2020 18:02:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Held (Code Review)

6:02 p.m.

Felix Held has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42611 )

Change subject: [UNTESTED] mb/google/zork: don't enable IRQ1/IRQ12 filter ......................................................................

Abandoned

1590

days inactive

1623

days old

coreboot-gerrit@coreboot.org

6 comments

3 participants

tags (0)

participants (3)

Eric Peers (Code Review)
Felix Held (Code Review)
Paul Menzel (Code Review)