Attention is currently required from: Bao Zheng, Zheng Bao. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63344 )
Change subject: amdfwtool: Add a flag to record the second gen instead of romsig ......................................................................
Patch Set 3:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/63344/comment/1beeb85a_28b40b30 PS3, Line 1387: if (cb_config->second_gen) { i think this has the logic backwards since EFS_SECOND_GEN is defined as 0. at least for me it would make the code less error-prone if cb_config->second_gen was a bool and EFS_SECOND_GEN and EFS_BEFORE_SECOND_GEN would only be used in this function for writing amd_romsig->efs_gen.gen, but not for cb_config->second_gen