Change in coreboot[master]: arch/x86/smbios: Measure execution time of `get_smbios_strings()`

[Paul Menzel (Code Review)]

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38314 )

Change subject: arch/x86/smbios: Measure execution time of `get_smbios_strings()`
......................................................................

arch/x86/smbios: Measure execution time of `get_smbios_strings()`

Change-Id: I97cfcd0849665b039920083bccfad8349d5de2c1
Signed-off-by: Paul Menzel 
---
M src/arch/x86/smbios.c
1 file changed, 7 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38314/1

diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c
index 8cd4518..7de9acb 100644
--- a/src/arch/x86/smbios.c
+++ b/src/arch/x86/smbios.c
@@ -28,6 +28,7 @@
 #include <device/pci_ids.h>
 #include <device/pci_def.h>
 #include <device/pci.h>
+#include <timer.h>
 #if CONFIG(CHROMEOS)
 #include <vendorcode/google/chromeos/gnvs.h>
 #endif
@@ -942,6 +943,7 @@
    struct smbios_type11 *t = (struct smbios_type11 *)*current;
    int len;
    struct device *dev;
+	struct stopwatch sw;

memset(t, 0, sizeof(*t));
    t->type = SMBIOS_OEM_STRINGS;
@@ -949,8 +951,12 @@
    t->length = len = sizeof(*t) - 2;

for (dev = all_devices; dev; dev = dev->next) {
-		if (dev->ops && dev->ops->get_smbios_strings)
+		if (dev->ops && dev->ops->get_smbios_strings) {
+			stopwatch_init_msecs(&sw);
    		dev->ops->get_smbios_strings(dev, t);
+			printk(BIOS_SPEW, "%s get_smbios_strings took %lu ms\n",
+				dev_path(dev), stopwatch_duration_msecs(&sw));
+		}
    }

if (t->count == 0) {

[Paul Menzel (Code Review)]

Paul Menzel has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/38314 )

Change subject: arch/x86/smbios: Measure execution time of `get_smbios_strings()`
......................................................................

arch/x86/smbios: Measure execution time of `get_smbios_strings()`

Change-Id: I97cfcd0849665b039920083bccfad8349d5de2c1
Signed-off-by: Paul Menzel 
---
M src/arch/x86/smbios.c
1 file changed, 7 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38314/2

[Alexander Couzens (Code Review)]

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38314 )

Change subject: arch/x86/smbios: Measure execution time of `get_smbios_strings()`
......................................................................

Patch Set 2:

Do you ran the code and have an example how much time is consumed? So far only the h8s or thinkpad supports get_smbios_strings()

[XS] Change in coreboot[master]: arch/x86/smbios: Measure execution time of `get_smbios_strings()`

[Stefan Reinauer (Code Review)]

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38314?usp=email )

Change subject: arch/x86/smbios: Measure execution time of `get_smbios_strings()`
......................................................................

Abandoned