Hello Chris Wang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/34902
to review the following change.
Change subject: mb/google/kahlee/treeya: Use GPIO_10 for EC_SYNC_IRQ ......................................................................
mb/google/kahlee/treeya: Use GPIO_10 for EC_SYNC_IRQ
Use AGPIO 10 as the EC sync interrupt for MKBP events for sensor data.
Reference to Aleena project.
BUG=b:135551210 BRANCH=grunt TEST=emerge-grunt coreboot
Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: Ie0b719ebce90710bca2109b7ff255e19329f9cac --- M src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h M src/mainboard/google/kahlee/variants/treeya/include/variant/gpio.h 2 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/34902/1
diff --git a/src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h b/src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h index 73e07ae..4a1c7fc 100644 --- a/src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h +++ b/src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h @@ -20,3 +20,9 @@
/* Enable Tablet switch */ #define EC_ENABLE_TBMC_DEVICE + +/* + * Enable EC sync interrupt via GPIO controller, EC_SYNC_IRQ is defined in + * variant/gpio.h + */ +#define EC_ENABLE_SYNC_IRQ_GPIO diff --git a/src/mainboard/google/kahlee/variants/treeya/include/variant/gpio.h b/src/mainboard/google/kahlee/variants/treeya/include/variant/gpio.h index 5a6b540..3ddabb1 100644 --- a/src/mainboard/google/kahlee/variants/treeya/include/variant/gpio.h +++ b/src/mainboard/google/kahlee/variants/treeya/include/variant/gpio.h @@ -14,3 +14,6 @@ */
#include <baseboard/gpio.h> + +/* EC sync irq is AGPIO 10 */ +#define EC_SYNC_IRQ 10
Edward Hill has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34902 )
Change subject: mb/google/kahlee/treeya: Use GPIO_10 for EC_SYNC_IRQ ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34902 )
Change subject: mb/google/kahlee/treeya: Use GPIO_10 for EC_SYNC_IRQ ......................................................................
mb/google/kahlee/treeya: Use GPIO_10 for EC_SYNC_IRQ
Use AGPIO 10 as the EC sync interrupt for MKBP events for sensor data.
Reference to Aleena project.
BUG=b:135551210 BRANCH=grunt TEST=emerge-grunt coreboot
Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: Ie0b719ebce90710bca2109b7ff255e19329f9cac Reviewed-on: https://review.coreboot.org/c/coreboot/+/34902 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Edward Hill ecgh@chromium.org --- M src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h M src/mainboard/google/kahlee/variants/treeya/include/variant/gpio.h 2 files changed, 9 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Edward Hill: Looks good to me, approved
diff --git a/src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h b/src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h index 73e07ae..4a1c7fc 100644 --- a/src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h +++ b/src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h @@ -20,3 +20,9 @@
/* Enable Tablet switch */ #define EC_ENABLE_TBMC_DEVICE + +/* + * Enable EC sync interrupt via GPIO controller, EC_SYNC_IRQ is defined in + * variant/gpio.h + */ +#define EC_ENABLE_SYNC_IRQ_GPIO diff --git a/src/mainboard/google/kahlee/variants/treeya/include/variant/gpio.h b/src/mainboard/google/kahlee/variants/treeya/include/variant/gpio.h index 5a6b540..3ddabb1 100644 --- a/src/mainboard/google/kahlee/variants/treeya/include/variant/gpio.h +++ b/src/mainboard/google/kahlee/variants/treeya/include/variant/gpio.h @@ -14,3 +14,6 @@ */
#include <baseboard/gpio.h> + +/* EC sync irq is AGPIO 10 */ +#define EC_SYNC_IRQ 10
-
chris wang (Code Review) -
Edward Hill (Code Review)
-
Martin Roth (Code Review)