Change in ...coreboot[master]: acpi: Add support for writing ACPI _PLD structures

[Matt Delco (Code Review)]

Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26171 )

Change subject: acpi: Add support for writing ACPI _PLD structures
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/26171/3/src/arch/x86/acpigen.c 
File src/arch/x86/acpigen.c:

https://review.coreboot.org/#/c/26171/3/src/arch/x86/acpigen.c@1239 
PS3, Line 1239: void acpigen_write_pld(const struct acpi_pld *pld)
This implementation doesn't appear to match the spec--it generates a buffer named _PLD, but the ACPI 6.2 spec says in 6.1.8 that the value of _PLD is "a variable-length Package containing a list of Buffers".  I noticed this while trying to port a coreboot asl file to a driver that calls acpigen_write_pld(). The asl file follows the acpi example (in section 19.6.141 in version 6.2) of "Name (_PLD, Package (0x01) { ToPLD () } ) and generates:

Package(_PLD:NumElements=1) { Buffer(Len=20) { ...} }

but this function generates:

Buffer(_PLD,Len=20) {  ... }