Attention is currently required from: Paul Fagerburg, Julius Werner, Jan Dabros.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54916 )
Change subject: tests: Add lib/cbmem_stage_cache-test test case
......................................................................
Patch Set 2:
(1 comment)
File tests/lib/cbmem_stage_cache-test.c:
https://review.coreboot.org/c/coreboot/+/54916/comment/1f236cf9_9e90301a
PS1, Line 137: void test_stage_cache_load_stage(void **state)
Can you add a comment here about what this test is checking?
Done. I also extended some of other comments
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54916
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6851b9473b225beb5ba51e26f44e21ea5919a64
Gerrit-Change-Number: 54916
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Fri, 28 May 2021 10:39:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-MessageType: comment