Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52466 )
Change subject: soc/intel/xeon_sp: Drop unused functions and prototypes ......................................................................
soc/intel/xeon_sp: Drop unused functions and prototypes
No definition exists for pmc_set_disb() and rtc_failure() is not called.
Change-Id: I3a68e1fc55c62193735a46caf9f70dd9ee0b7349 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/52466 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Marc Jones marc@marcjonesconsulting.com --- M src/soc/intel/xeon_sp/include/soc/pm.h M src/soc/intel/xeon_sp/pmutil.c 2 files changed, 0 insertions(+), 22 deletions(-)
Approvals: build bot (Jenkins): Verified Marc Jones: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/soc/intel/xeon_sp/include/soc/pm.h b/src/soc/intel/xeon_sp/include/soc/pm.h index 8c26c6a..b4d6df9 100644 --- a/src/soc/intel/xeon_sp/include/soc/pm.h +++ b/src/soc/intel/xeon_sp/include/soc/pm.h @@ -117,12 +117,6 @@ /* Get base address PMC memory mapped registers. */ uint8_t *pmc_mmio_regs(void);
-/* Set the DISB after DRAM init */ -void pmc_set_disb(void); - -/* Return non-zero when RTC failure happened. */ -int rtc_failure(void); - uint16_t get_pmbase(void);
void pmc_lock_smi(void); diff --git a/src/soc/intel/xeon_sp/pmutil.c b/src/soc/intel/xeon_sp/pmutil.c index b057ab2..c63285c 100644 --- a/src/soc/intel/xeon_sp/pmutil.c +++ b/src/soc/intel/xeon_sp/pmutil.c @@ -126,22 +126,6 @@ return rtc_fail; }
-int rtc_failure(void) -{ - u8 reg8; - int rtc_failed; - /* PMC Controller Device 0x1F, Func 02 */ - reg8 = pci_read_config8(PCH_DEV_PMC, GEN_PMCON_B); - rtc_failed = reg8 & RTC_BATTERY_DEAD; - if (rtc_failed) { - reg8 &= ~RTC_BATTERY_DEAD; - pci_write_config8(PCH_DEV_PMC, GEN_PMCON_B, reg8); - printk(BIOS_DEBUG, "rtc_failed = 0x%x\n", rtc_failed); - } - - return !!rtc_failed; -} - /* Return 0, 3, or 5 to indicate the previous sleep state. */ int soc_prev_sleep_state(const struct chipset_power_state *ps, int prev_sleep_state) {