Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29954 )
Change subject: qcs405: Add DRAM resources ......................................................................
Patch Set 13: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/29954/13/src/soc/qualcomm/qcs405/include/soc... File src/soc/qualcomm/qcs405/include/soc/memlayout.ld:
https://review.coreboot.org/#/c/29954/13/src/soc/qualcomm/qcs405/include/soc... PS13, Line 46: Just curious, but is there any particular reason for moving them away from here? The new reserved region is from 0x8500_0000 to 0x8A10_0000, so no conflict.
If it doesn't matter, we can leave the new addresses in, because they're as good as any, but some explanation why these were chosen would be nice.
-
Patrick Georgi (Code Review)