Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40565 )
Change subject: util/scripts/ucode_h_to_bin.sh: Drop disruptive quotes ......................................................................
util/scripts/ucode_h_to_bin.sh: Drop disruptive quotes
The double quotes around the remaining shell parameters '${@:2}' causes that the provided *.h files in $(CONFIG_CPU_MICROCODE_HEADER_FILES), which is a space separated list, cannot be broken down to every single file as needed but stay as a single parameter in the for-loop. Therefore, the called function 'include_file' will get a single parameter with all files which will lead to a broken C code in terms of a wrong #include-syntax. This causes the script to fail.
To fix this remove the double quotes which works just fine.
Change-Id: Iab7b0dc8d850973d6af764899907d383e9ec7743 Signed-off-by: Werner Zeh werner.zeh@siemens.com --- M util/scripts/ucode_h_to_bin.sh 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/40565/1
diff --git a/util/scripts/ucode_h_to_bin.sh b/util/scripts/ucode_h_to_bin.sh index e6f4699..2010c48 100755 --- a/util/scripts/ucode_h_to_bin.sh +++ b/util/scripts/ucode_h_to_bin.sh @@ -49,7 +49,7 @@ fi }
-for UCODE in "${@:2}"; do +for UCODE in ${@:2}; do if [ -d "$UCODE" ]; then for f in "$UCODE/"*.inc do
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40565 )
Change subject: util/scripts/ucode_h_to_bin.sh: Drop disruptive quotes ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40565 )
Change subject: util/scripts/ucode_h_to_bin.sh: Drop disruptive quotes ......................................................................
util/scripts/ucode_h_to_bin.sh: Drop disruptive quotes
The double quotes around the remaining shell parameters '${@:2}' causes that the provided *.h files in $(CONFIG_CPU_MICROCODE_HEADER_FILES), which is a space separated list, cannot be broken down to every single file as needed but stay as a single parameter in the for-loop. Therefore, the called function 'include_file' will get a single parameter with all files which will lead to a broken C code in terms of a wrong #include-syntax. This causes the script to fail.
To fix this remove the double quotes which works just fine.
Change-Id: Iab7b0dc8d850973d6af764899907d383e9ec7743 Signed-off-by: Werner Zeh werner.zeh@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40565 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/scripts/ucode_h_to_bin.sh 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/util/scripts/ucode_h_to_bin.sh b/util/scripts/ucode_h_to_bin.sh index e6f4699..2010c48 100755 --- a/util/scripts/ucode_h_to_bin.sh +++ b/util/scripts/ucode_h_to_bin.sh @@ -49,7 +49,7 @@ fi }
-for UCODE in "${@:2}"; do +for UCODE in ${@:2}; do if [ -d "$UCODE" ]; then for f in "$UCODE/"*.inc do
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Werner Zeh (Code Review)